mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Closes #7118: Render URL custom fields as hyperlinks in object tables

Browse Source
This commit is contained in:
jeremystretch
2021-09-21 14:04:47 -04:00
parent 2a1718bfc8
commit 3cf1d6baf4
2 changed files with 5 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/release-notes/version-3.0.md
View File

@@ -4,6 +4,7 @@
### Enhancements ### Enhancements
* [#7118](https://github.com/netbox-community/netbox/issues/7118) - Render URL custom fields as hyperlinks in object tables
* [#7323](https://github.com/netbox-community/netbox/issues/7323) - Add serial filter field for racks & devices * [#7323](https://github.com/netbox-community/netbox/issues/7323) - Add serial filter field for racks & devices
### Bug Fixes ### Bug Fixes

4
netbox/utilities/tables.py
View File

@@ -11,6 +11,7 @@ from django_tables2 import RequestConfig
from django_tables2.data import TableQuerysetData from django_tables2.data import TableQuerysetData
from django_tables2.utils import Accessor from django_tables2.utils import Accessor
from extras.choices import CustomFieldTypeChoices
from extras.models import CustomField from extras.models import CustomField
from .utils import content_type_name from .utils import content_type_name
from .paginator import EnhancedPaginator, get_paginate_count from .paginator import EnhancedPaginator, get_paginate_count
@@ -355,6 +356,9 @@ class CustomFieldColumn(tables.Column):
def render(self, value): def render(self, value):
if isinstance(value, list): if isinstance(value, list):
return ', '.join(v for v in value) return ', '.join(v for v in value)
elif self.customfield.type == CustomFieldTypeChoices.TYPE_URL:
# Linkify custom URLs
return mark_safe(f'<a href="{value}">{value}</a>')
return value or self.default return value or self.default