mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Closes #5995: Dropped backward compatibility for queryset parameter on ObjectVar and MultiObjectVar

Browse Source
This commit is contained in:
Jeremy Stretch
2021-03-16 11:28:50 -04:00
parent a694dbb020
commit 46a024441c
2 changed files with 3 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
netbox/extras/scripts.py
View File

@@ -186,7 +186,7 @@ class ObjectVar(ScriptVariable):
"""
form_field = DynamicModelChoiceField
def __init__(self, model=None, queryset=None, query_params=None, null_option=None, *args, **kwargs):
def __init__(self, model, query_params=None, null_option=None, *args, **kwargs):
# TODO: Remove display_field in v2.12
if 'display_field' in kwargs:
@@ -198,18 +198,8 @@ class ObjectVar(ScriptVariable):
super().__init__(*args, **kwargs)
# Set the form field's queryset. Support backward compatibility for the "queryset" argument for now.
if model is not None:
self.field_attrs['queryset'] = model.objects.all()
elif queryset is not None:
warnings.warn(
f'{self}: Specifying a queryset for ObjectVar is no longer supported. Please use "model" instead.'
)
self.field_attrs['queryset'] = queryset
else:
raise TypeError('ObjectVar must specify a model')
self.field_attrs.update({
'queryset': model.objects.all(),
'display_field': display_field,
'query_params': query_params,
'null_option': null_option,