mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Replaced ASN bounds with constants

Browse Source
This commit is contained in:
Saria Hajjar
2020-01-09 21:58:38 +00:00
parent 4eacc57522
commit 6c19c88e99
3 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
netbox/dcim/constants.py
View File

@ -1,4 +1,8 @@
# BGP ASN bounds
BGP_ASN_MIN = 1
BGP_ASN_MAX = 2**32 - 1
# Rack types # Rack types
RACK_TYPE_2POST = 100 RACK_TYPE_2POST = 100
RACK_TYPE_4POST = 200 RACK_TYPE_4POST = 200

8
netbox/dcim/fields.py
View File

@ -3,16 +3,18 @@ from django.core.validators import MinValueValidator, MaxValueValidator
from django.db import models from django.db import models
from netaddr import AddrFormatError, EUI, mac_unix_expanded from netaddr import AddrFormatError, EUI, mac_unix_expanded
from .constants import *
class ASNField(models.BigIntegerField): class ASNField(models.BigIntegerField):
description = "32-bit ASN field" description = "32-bit ASN field"
default_validators = [ default_validators = [
MinValueValidator(1), MinValueValidator(BGP_ASN_MIN),
MaxValueValidator(4294967295), MaxValueValidator(BGP_ASN_MAX),
] ]
def formfield(self, **kwargs): def formfield(self, **kwargs):
defaults = {'min_value': 1, 'max_value': 4294967295} defaults = {'min_value': BGP_ASN_MIN, 'max_value': BGP_ASN_MAX}
defaults.update(**kwargs) defaults.update(**kwargs)
return super().formfield(**defaults) return super().formfield(**defaults)

4
netbox/dcim/forms.py
View File

@ -292,8 +292,8 @@ class SiteBulkEditForm(BootstrapMixin, AddRemoveTagsForm, CustomFieldBulkEditFor
) )
) )
asn = forms.IntegerField( asn = forms.IntegerField(
min_value=1, min_value=BGP_ASN_MIN,
max_value=4294967295, max_value=BGP_ASN_MAX,
required=False, required=False,
label='ASN' label='ASN'
) )