mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Raise specific exceptions

Browse Source
This commit is contained in:
Jeremy Stretch
2020-03-18 13:15:22 -04:00
parent 043b1c28d2
commit 70c29051b3
2 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
netbox/extras/registry.py
View File

@ -7,15 +7,15 @@ class Registry(dict):
try: try:
return super().__getitem__(key) return super().__getitem__(key)
except KeyError: except KeyError:
raise Exception("Invalid store: {}".format(key)) raise KeyError("Invalid store: {}".format(key))
def __setitem__(self, key, value): def __setitem__(self, key, value):
if key in self: if key in self:
raise Exception("Store already set: {}".format(key)) raise KeyError("Store already set: {}".format(key))
super().__setitem__(key, value) super().__setitem__(key, value)
def __delitem__(self, key): def __delitem__(self, key):
raise Exception("Cannot delete stores from registry") raise TypeError("Cannot delete stores from registry")
registry = Registry() registry = Registry()

4
netbox/extras/tests/test_registry.py
View File

@ -22,12 +22,12 @@ class RegistryTest(TestCase):
reg = Registry() reg = Registry()
reg['foo'] = 123 reg['foo'] = 123
with self.assertRaises(Exception): with self.assertRaises(KeyError):
reg['foo'] = 456 reg['foo'] = 456
def test_delete_store(self): def test_delete_store(self):
reg = Registry() reg = Registry()
reg['foo'] = 123 reg['foo'] = 123
with self.assertRaises(Exception): with self.assertRaises(TypeError):
del(reg['foo']) del(reg['foo'])