mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Adds to NAPALM, name lookup if no primary IP address for device

Browse Source
This commit is contained in:
Josh VanDeraa
2020-07-10 15:12:25 -05:00
parent fa9ffb23ad
commit 7788bf3ce3
1 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
netbox/dcim/api/views.py
View File

@ -1,3 +1,4 @@
import socket
from collections import OrderedDict from collections import OrderedDict
from django.conf import settings from django.conf import settings
@ -371,8 +372,6 @@ class DeviceViewSet(CustomFieldModelViewSet):
Execute a NAPALM method on a Device Execute a NAPALM method on a Device
""" """
device = get_object_or_404(Device, pk=pk) device = get_object_or_404(Device, pk=pk)
if not device.primary_ip:
raise ServiceUnavailable("This device does not have a primary IP address configured.")
if device.platform is None: if device.platform is None:
raise ServiceUnavailable("No platform is configured for this device.") raise ServiceUnavailable("No platform is configured for this device.")
if not device.platform.napalm_driver: if not device.platform.napalm_driver:
@ -402,7 +401,18 @@ class DeviceViewSet(CustomFieldModelViewSet):
# Connect to the device # Connect to the device
napalm_methods = request.GET.getlist('method') napalm_methods = request.GET.getlist('method')
response = OrderedDict([(m, None) for m in napalm_methods]) response = OrderedDict([(m, None) for m in napalm_methods])
ip_address = str(device.primary_ip.address.ip)
# Check for primary IP address from NetBox object
if device.primary_ip:
host = str(device.primary_ip.address.ip)
else:
# Attempt to complete a DNS name resolution if no primary_ip is set
try:
host = socket.gethostbyname(device.name)
except socket.gaierror:
# Name lookup failure
raise ServiceUnavailable(f"Name lookup failure, unable to resolve IP address for {device.name}. Please set Primary IP or setup name resolution.")
username = settings.NAPALM_USERNAME username = settings.NAPALM_USERNAME
password = settings.NAPALM_PASSWORD password = settings.NAPALM_PASSWORD
optional_args = settings.NAPALM_ARGS.copy() optional_args = settings.NAPALM_ARGS.copy()
@ -423,7 +433,7 @@ class DeviceViewSet(CustomFieldModelViewSet):
optional_args[key.lower()] = request.headers[header] optional_args[key.lower()] = request.headers[header]
d = driver( d = driver(
hostname=ip_address, hostname=host,
username=username, username=username,
password=password, password=password,
timeout=settings.NAPALM_TIMEOUT, timeout=settings.NAPALM_TIMEOUT,
@ -432,7 +442,7 @@ class DeviceViewSet(CustomFieldModelViewSet):
try: try:
d.open() d.open()
except Exception as e: except Exception as e:
raise ServiceUnavailable("Error connecting to the device at {}: {}".format(ip_address, e)) raise ServiceUnavailable("Error connecting to the device at {}: {}".format(host, e))
# Validate and execute each specified NAPALM method # Validate and execute each specified NAPALM method
for method in napalm_methods: for method in napalm_methods: