mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

#12589: Move username validation from form to NetBoxUser

Browse Source
This commit is contained in:
Jeremy Stretch
2023-08-01 15:42:47 -04:00
parent ccb7568462
commit 79030ecab2
2 changed files with 9 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
netbox/users/forms/model_forms.py
View File

@@ -229,25 +229,6 @@ class UserForm(BootstrapMixin, forms.ModelForm):
if self.cleaned_data['password'] and self.cleaned_data['password'] != self.cleaned_data['confirm_password']:
raise forms.ValidationError(_("Passwords do not match! Please check your input and try again."))
# TODO: Move this logic to the NetBoxUser class
def clean_username(self):
"""Reject usernames that differ only in case."""
instance = getattr(self, 'instance', None)
if instance:
qs = self._meta.model.objects.exclude(pk=instance.pk)
else:
qs = self._meta.model.objects.all()
username = self.cleaned_data.get("username")
if (
username and qs.filter(username__iexact=username).exists()
):
raise forms.ValidationError(
_("user with this username already exists")
)
return username
class GroupForm(BootstrapMixin, forms.ModelForm):
users = DynamicModelMultipleChoiceField(