mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Fixes #6686: Force assignment of null custom field values to objects

Browse Source
This commit is contained in:
jeremystretch
2021-08-16 14:38:06 -04:00
parent 5b89cdc868
commit 9b0258fef4
4 changed files with 38 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
netbox/extras/models/customfields.py
View File

@@ -120,17 +120,16 @@ class CustomField(BigIDModel):
# Cache instance's original name so we can check later whether it has changed
self._name = self.name
def rename_object_data(self, old_name, new_name):
def populate_initial_data(self, content_types):
"""
Called when a CustomField has been renamed. Updates all assigned object data.
Populate initial custom field data upon either a) the creation of a new CustomField, or
b) the assignment of an existing CustomField to new object types.
"""
for ct in self.content_types.all():
for ct in content_types:
model = ct.model_class()
params = {f'custom_field_data__{old_name}__isnull': False}
instances = model.objects.filter(**params)
for instance in instances:
instance.custom_field_data[new_name] = instance.custom_field_data.pop(old_name)
model.objects.bulk_update(instances, ['custom_field_data'], batch_size=100)
for obj in model.objects.exclude(**{f'custom_field_data__contains': self.name}):
obj.custom_field_data[self.name] = self.default
obj.save()
def remove_stale_data(self, content_types):
"""
@@ -143,6 +142,18 @@ class CustomField(BigIDModel):
del(obj.custom_field_data[self.name])
obj.save()
def rename_object_data(self, old_name, new_name):
"""
Called when a CustomField has been renamed. Updates all assigned object data.
"""
for ct in self.content_types.all():
model = ct.model_class()
params = {f'custom_field_data__{old_name}__isnull': False}
instances = model.objects.filter(**params)
for instance in instances:
instance.custom_field_data[new_name] = instance.custom_field_data.pop(old_name)
model.objects.bulk_update(instances, ['custom_field_data'], batch_size=100)
def clean(self):
super().clean()