mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Fixes #2608: Fixed null outer_unit error on rack import

Browse Source
This commit is contained in:
Jeremy Stretch
2018-11-26 13:41:35 -05:00
parent d59be2912e
commit a46f68c6e4
2 changed files with 5 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
CHANGELOG.md
View File

@ -60,6 +60,7 @@ NetBox now supports modeling physical cables for console, power, and interface c
* [#2593](https://github.com/digitalocean/netbox/issues/2593) - Fix toggling of connected cable's status
* [#2601](https://github.com/digitalocean/netbox/issues/2601) - Added a `description` field to pass-through ports
* [#2602](https://github.com/digitalocean/netbox/issues/2602) - Return HTTP 204 when no new IPs/prefixes are available for provisioning
* [#2608](https://github.com/digitalocean/netbox/issues/2608) - Fixed null `outer_unit` error on rack import
## API Changes

10
netbox/dcim/models.py
View File

@ -552,12 +552,10 @@ class Rack(ChangeLoggedModel, CustomFieldModel):
def clean(self):
# Validate outer dimensions and unit
if self.outer_width and not self.outer_unit:
raise ValidationError("Must specify a unit when setting an outer width")
if self.outer_depth and not self.outer_unit:
raise ValidationError("Must specify a unit when setting an outer depth")
if self.outer_unit and self.outer_width is None and self.outer_depth is None:
self.length_unit = ''
if (self.outer_width or self.outer_depth) and not self.outer_unit:
raise ValidationError("Must specify a unit when setting an outer width/depth")
else:
self.outer_unit = ''
if self.pk:
# Validate that Rack is tall enough to house the installed Devices