1
0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00

Add bridge to InterfaceTemplate

This commit is contained in:
kkthxbye-code
2023-03-01 16:05:41 +01:00
committed by Jeremy Stretch
parent c44eb65993
commit a74ae46f86
6 changed files with 78 additions and 4 deletions

View File

@@ -350,6 +350,14 @@ class InterfaceTemplate(ModularComponentTemplateModel):
default=False,
verbose_name='Management only'
)
bridge = models.ForeignKey(
to='self',
on_delete=models.SET_NULL,
related_name='bridge_interfaces',
null=True,
blank=True,
verbose_name='Bridge interface'
)
poe_mode = models.CharField(
max_length=50,
choices=InterfacePoEModeChoices,
@@ -365,6 +373,19 @@ class InterfaceTemplate(ModularComponentTemplateModel):
component_model = Interface
def clean(self):
super().clean()
if self.bridge:
if self.device_type and self.device_type != self.bridge.device_type:
raise ValidationError({
'bridge': f"Bridge interface ({self.bridge}) must belong to the same device type"
})
if self.module_type and self.module_type != self.bridge.module_type:
raise ValidationError({
'bridge': f"Bridge interface ({self.bridge}) must belong to the same module type"
})
def instantiate(self, **kwargs):
return self.component_model(
name=self.resolve_name(kwargs.get('module')),
@@ -385,6 +406,7 @@ class InterfaceTemplate(ModularComponentTemplateModel):
'mgmt_only': self.mgmt_only,
'label': self.label,
'description': self.description,
'bridge': self.bridge.name if self.bridge else None,
'poe_mode': self.poe_mode,
'poe_type': self.poe_type,
}

View File

@@ -802,6 +802,15 @@ class Device(PrimaryModel, ConfigContextModel):
'vc_position': "A device assigned to a virtual chassis must have its position defined."
})
def _update_interface_bridges(self, interface_templates, module=None):
for interface_template in interface_templates.exclude(bridge=None):
interface = Interface.objects.get(device=self, name=interface_template.resolve_name(module=module))
if interface_template.bridge:
interface.bridge = Interface.objects.get(device=self, name=interface_template.bridge.resolve_name(module=module))
interface.full_clean()
interface.save()
def _instantiate_components(self, queryset, bulk_create=True):
"""
Instantiate components for the device from the specified component templates.
@@ -854,6 +863,8 @@ class Device(PrimaryModel, ConfigContextModel):
self._instantiate_components(self.device_type.devicebaytemplates.all())
# Disable bulk_create to accommodate MPTT
self._instantiate_components(self.device_type.inventoryitemtemplates.all(), bulk_create=False)
# Interface bridges have to be set after interface instantiation
self._update_interface_bridges(self.device_type.interfacetemplates.all())
# Update Site and Rack assignment for any child Devices
devices = Device.objects.filter(parent_bay__device=self)
@@ -1015,6 +1026,15 @@ class Module(PrimaryModel, ConfigContextModel):
f"Module must be installed within a module bay belonging to the assigned device ({self.device})."
)
def _update_interface_bridges(self, interface_templates, module=None):
for interface_template in interface_templates.exclude(bridge=None):
interface = Interface.objects.get(device=self.device, name=interface_template.resolve_name(module=module))
if interface_template.bridge:
interface.bridge = Interface.objects.get(device=self.device, name=interface_template.bridge.resolve_name(module=module))
interface.full_clean()
interface.save()
def save(self, *args, **kwargs):
is_new = self.pk is None
@@ -1090,6 +1110,9 @@ class Module(PrimaryModel, ConfigContextModel):
update_fields=update_fields
)
# Interface bridges have to be set after interface instantiation
self._update_interface_bridges(self.module_type.interfacetemplates, self)
#
# Virtual chassis