Standardized implementation of nested ViewSets

netbox/secrets/api/urls.py

@@ -2,29 +2,21 @@ from django.conf.urls import include, url
 
 from rest_framework import routers
 
-from .views import (
-
-    # Viewsets
-    SecretRoleViewSet,
-
-    # Legacy views
-    RSAKeyGeneratorView, SecretDetailView, SecretListView,
-
-)
+from . import views
 
 
 router = routers.DefaultRouter()
-router.register(r'secret-roles', SecretRoleViewSet)
+router.register(r'secret-roles', views.SecretRoleViewSet)
 
 urlpatterns = [
 
     url(r'', include(router.urls)),
 
     # Secrets
-    url(r'^secrets/$', SecretListView.as_view(), name='secret_list'),
-    url(r'^secrets/(?P<pk>\d+)/$', SecretDetailView.as_view(), name='secret_detail'),
+    url(r'^secrets/$', views.SecretListView.as_view(), name='secret_list'),
+    url(r'^secrets/(?P<pk>\d+)/$', views.SecretDetailView.as_view(), name='secret_detail'),
 
     # Miscellaneous
-    url(r'^generate-keys/$', RSAKeyGeneratorView.as_view(), name='generate_keys'),
+    url(r'^generate-keys/$', views.RSAKeyGeneratorView.as_view(), name='generate_keys'),
 
 ]

netbox/secrets/api/views.py

@@ -28,9 +28,6 @@ ERR_PRIVKEY_INVALID = "Invalid private key."
 #
 
 class SecretRoleViewSet(ModelViewSet):
-    """
-    List and retrieve secret roles
-    """
     queryset = SecretRole.objects.all()
     serializer_class = serializers.SecretRoleSerializer
     permission_classes = [IsAuthenticated]