mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

#10221: Tweak variable names & error message

Browse Source
This commit is contained in:
jeremystretch
2023-04-10 14:03:59 -04:00
parent b41f8755df
commit ada01b39cc
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
netbox/netbox/models/__init__.py
View File

@ -67,23 +67,23 @@ class NetBoxModel(CloningMixin, NetBoxFeatureSet, models.Model):
for field in self._meta.get_fields(): for field in self._meta.get_fields():
if isinstance(field, GenericForeignKey): if isinstance(field, GenericForeignKey):
ct_field = getattr(self, field.ct_field) ct_value = getattr(self, field.ct_field)
fk_field = getattr(self, field.fk_field) fk_value = getattr(self, field.fk_field)
if ct_field is None and fk_field is not None: if ct_value is None and fk_value is not None:
raise ValidationError({ raise ValidationError({
field.ct_field: "This field cannot be null.", field.ct_field: "This field cannot be null.",
}) })
if fk_field is None and ct_field is not None: if fk_value is None and ct_value is not None:
raise ValidationError({ raise ValidationError({
field.fk_field: "This field cannot be null.", field.fk_field: "This field cannot be null.",
}) })
if ct_field and fk_field: if ct_value and fk_value:
klass = getattr(self, field.ct_field).model_class() klass = getattr(self, field.ct_field).model_class()
if not klass.objects.filter(pk=fk_field).exists(): if not klass.objects.filter(pk=fk_value).exists():
raise ValidationError({ raise ValidationError({
field.fk_field: f"Invalid {fk_field}: object does not exist on {ct_field}." field.fk_field: f"Related object not found using the provided value: {fk_value}."
}) })