From b7a96a33efe25e84a0e8ffebc3d3280dda0ae9c9 Mon Sep 17 00:00:00 2001 From: Jeremy Stretch Date: Thu, 7 May 2020 10:34:33 -0400 Subject: [PATCH] Fixes #4598: Display error message when invalid cable length is specified --- docs/release-notes/version-2.8.md | 8 ++++++++ netbox/dcim/forms.py | 5 +++++ netbox/templates/dcim/inc/cable_form.html | 14 ++++++++++++++ 3 files changed, 27 insertions(+) diff --git a/docs/release-notes/version-2.8.md b/docs/release-notes/version-2.8.md index e3bd6b512..e1dfaddbb 100644 --- a/docs/release-notes/version-2.8.md +++ b/docs/release-notes/version-2.8.md @@ -1,5 +1,13 @@ # NetBox v2.8 +v2.8.4 (FUTURE) + +### Bug Fixes + +* [#4598](https://github.com/netbox-community/netbox/issues/4598) - Display error message when invalid cable length is specified + +--- + ## v2.8.3 (2020-05-06) ### Bug Fixes diff --git a/netbox/dcim/forms.py b/netbox/dcim/forms.py index b104124b4..2116d0948 100644 --- a/netbox/dcim/forms.py +++ b/netbox/dcim/forms.py @@ -3659,6 +3659,11 @@ class CableForm(BootstrapMixin, forms.ModelForm): 'type': StaticSelect2, 'length_unit': StaticSelect2, } + error_messages = { + 'length': { + 'max_value': 'Maximum length is 32767 (any unit)' + } + } class CableCSVForm(CSVModelForm): diff --git a/netbox/templates/dcim/inc/cable_form.html b/netbox/templates/dcim/inc/cable_form.html index 0799eb130..a52cc302e 100644 --- a/netbox/templates/dcim/inc/cable_form.html +++ b/netbox/templates/dcim/inc/cable_form.html @@ -10,9 +10,23 @@
{{ form.length }} + {% if form.length.errors %} + + {% endif %}
{{ form.length_unit }} + {% if form.length_unit.errors %} + + {% endif %}