mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Fixes #10220: Validate IP version when assigning primary IPs to a virtual machine

Browse Source
This commit is contained in:
jeremystretch
2022-09-01 09:31:42 -04:00
parent 899b61264f
commit d818c250b0
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
docs/release-notes/version-3.3.md
View File

@ -24,6 +24,7 @@
* [#10181](https://github.com/netbox-community/netbox/issues/10181) - Restore MultiPartParser (regression from #10031) * [#10181](https://github.com/netbox-community/netbox/issues/10181) - Restore MultiPartParser (regression from #10031)
* [#10208](https://github.com/netbox-community/netbox/issues/10208) - Fix permissions evaluation for interface actions dropdown menu * [#10208](https://github.com/netbox-community/netbox/issues/10208) - Fix permissions evaluation for interface actions dropdown menu
* [#10217](https://github.com/netbox-community/netbox/issues/10217) - Handle exception when trace splits to multiple rear ports * [#10217](https://github.com/netbox-community/netbox/issues/10217) - Handle exception when trace splits to multiple rear ports
* [#10220](https://github.com/netbox-community/netbox/issues/10220) - Validate IP version when assigning primary IPs to a virtual machine
--- ---

7
netbox/virtualization/models.py
View File

@ -368,9 +368,14 @@ class VirtualMachine(NetBoxModel, ConfigContextModel):
# Validate primary IP addresses # Validate primary IP addresses
interfaces = self.interfaces.all() interfaces = self.interfaces.all()
for field in ['primary_ip4', 'primary_ip6']: for family in (4, 6):
field = f'primary_ip{family}'
ip = getattr(self, field) ip = getattr(self, field)
if ip is not None: if ip is not None:
if ip.address.version != family:
raise ValidationError({
field: f"Must be an IPv{family} address. ({ip} is an IPv{ip.address.version} address.)",
})
if ip.assigned_object in interfaces: if ip.assigned_object in interfaces:
pass pass
elif ip.nat_inside is not None and ip.nat_inside.assigned_object in interfaces: elif ip.nat_inside is not None and ip.nat_inside.assigned_object in interfaces: