mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Always pass obj=None to ModelBackend

Browse Source
This commit is contained in:
Jeremy Stretch
2020-05-11 17:19:11 -04:00
parent 63f842c7db
commit daa2c6ff21
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
netbox/utilities/auth_backends.py
View File

@ -3,8 +3,6 @@ import logging
from django.conf import settings from django.conf import settings
from django.contrib.auth.backends import ModelBackend, RemoteUserBackend as RemoteUserBackend_ from django.contrib.auth.backends import ModelBackend, RemoteUserBackend as RemoteUserBackend_
from django.contrib.auth.models import Group, Permission from django.contrib.auth.models import Group, Permission
from django.contrib.contenttypes.models import ContentType
from django.db.models import Q
from users.models import ObjectPermission from users.models import ObjectPermission
@ -26,13 +24,16 @@ class ViewExemptModelBackend(ModelBackend):
'*' in settings.EXEMPT_VIEW_PERMISSIONS '*' in settings.EXEMPT_VIEW_PERMISSIONS
) or ( ) or (
# This specific model is exempt from view permission enforcement # This specific model is exempt from view permission enforcement
'{}.{}'.format(app, model) in settings.EXEMPT_VIEW_PERMISSIONS '.'.join((app, model)) in settings.EXEMPT_VIEW_PERMISSIONS
): ):
return True return True
except ValueError: except ValueError:
pass pass
return super().has_perm(user_obj, perm, obj) # Fall back to ModelBackend's default behavior, with one exception: Set obj to None. Model-level permissions
# override object-level permissions, so if a user has the model-level permission we can ignore any specified
# object. (By default, ModelBackend will return False if an object is specified.)
return super().has_perm(user_obj, perm, None)
class ObjectPermissionBackend(ModelBackend): class ObjectPermissionBackend(ModelBackend):
@ -56,9 +57,8 @@ class ObjectPermissionBackend(ModelBackend):
if model._meta.model_name != model_name: if model._meta.model_name != model_name:
raise ValueError(f"Invalid permission {perm} for model {model}") raise ValueError(f"Invalid permission {perm} for model {model}")
# Attempt to retrieve the model from the database using the # Attempt to retrieve the model from the database using the attributes defined in the
# attributes defined in the ObjectPermission. If we have a # ObjectPermission. If we have a match, assert that the user has permission.
# match, assert that the user has permission.
attrs = ObjectPermission.objects.get_attr_constraints(user_obj, obj, action) attrs = ObjectPermission.objects.get_attr_constraints(user_obj, obj, action)
if model.objects.filter(pk=obj.pk, **attrs).exists(): if model.objects.filter(pk=obj.pk, **attrs).exists():
return True return True