mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Fixes #7075: Wrap label selectors in quotes to ensure IDs with spaces are properly selected

Browse Source
This commit is contained in:
thatmattlove
2021-08-30 17:48:33 -07:00
parent bf05bc2986
commit db2993035d
4 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
netbox/project-static/dist/netbox.js vendored
View File

File diff suppressed because one or more lines are too long

2
netbox/project-static/dist/netbox.js.map vendored
View File

File diff suppressed because one or more lines are too long

2
netbox/project-static/src/select/api/apiSelect.ts
View File

@ -715,7 +715,7 @@ export class APISelect {
private getPlaceholder(): string { private getPlaceholder(): string {
let placeholder = this.name; let placeholder = this.name;
if (this.base.id) { if (this.base.id) {
const label = document.querySelector(`label[for=${this.base.id}]`) as HTMLLabelElement; const label = document.querySelector(`label[for="${this.base.id}"]`) as HTMLLabelElement;
// Set the placeholder text to the label value, if it exists. // Set the placeholder text to the label value, if it exists.
if (label !== null) { if (label !== null) {
placeholder = `Select ${label.innerText.trim()}`; placeholder = `Select ${label.innerText.trim()}`;

2
netbox/project-static/src/select/static.ts
View File

@ -4,7 +4,7 @@ import { getElements } from '../util';
export function initStaticSelect(): void { export function initStaticSelect(): void {
for (const select of getElements<HTMLSelectElement>('.netbox-static-select')) { for (const select of getElements<HTMLSelectElement>('.netbox-static-select')) {
if (select !== null) { if (select !== null) {
const label = document.querySelector(`label[for=${select.id}]`) as HTMLLabelElement; const label = document.querySelector(`label[for="${select.id}"]`) as HTMLLabelElement;
let placeholder; let placeholder;
if (label !== null) { if (label !== null) {