mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

fixed #1921 - create interfaces with 801.1q in api

Browse Source
This commit is contained in:
John Anderson
2018-02-27 16:19:28 -05:00
parent 970759ed8b
commit e4c1cece75
2 changed files with 81 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
netbox/dcim/api/serializers.py
View File

@ -734,14 +734,30 @@ class WritableInterfaceSerializer(ValidatedModelSerializer):
# Validate that all untagged VLANs either belong to the same site as the Interface's parent Deivce or
# VirtualMachine, or are global.
parent = self.instance.parent if self.instance else data.get('device') or data.get('virtual_machine')
for vlan in data.get('tagged_vlans', []):
tagged_vlans = data.pop('tagged_vlans', [])
for vlan in tagged_vlans:
if vlan.site not in [parent, None]:
raise serializers.ValidationError(
"Tagged VLAN {} must belong to the same site as the interface's parent device/VM, or it must be "
"global".format(vlan)
)
return super(WritableInterfaceSerializer, self).validate(data)
validated_data = super(WritableInterfaceSerializer, self).validate(data)
if tagged_vlans:
validated_data['tagged_vlans'] = tagged_vlans
return validated_data
def create(self, validated_data):
"""
Becasue tagged_vlans is a M2M relationship, we have to create the interface first
"""
tagged_vlans = validated_data.pop('tagged_vlans', None)
interface = Interface.objects.create(**validated_data)
interface.save()
if tagged_vlans:
interface.tagged_vlans = tagged_vlans
interface.save()
return interface
#