diff --git a/netbox/ipam/api/serializers.py b/netbox/ipam/api/serializers.py index 1ab9bfbfe..e632111ab 100644 --- a/netbox/ipam/api/serializers.py +++ b/netbox/ipam/api/serializers.py @@ -78,7 +78,6 @@ class AggregateNestedSerializer(AggregateSerializer): # class VLANSerializer(serializers.ModelSerializer): - display_name = serializers.SerializerMethodField() site = SiteNestedSerializer() role = RoleNestedSerializer() @@ -86,9 +85,6 @@ class VLANSerializer(serializers.ModelSerializer): model = VLAN fields = ['id', 'site', 'vid', 'name', 'status', 'role', 'display_name'] - def get_display_name(self, obj): - return "{} ({})".format(obj.vid, obj.name) - class VLANNestedSerializer(VLANSerializer): diff --git a/netbox/ipam/models.py b/netbox/ipam/models.py index cbfae0d5d..b04f9b1c7 100644 --- a/netbox/ipam/models.py +++ b/netbox/ipam/models.py @@ -344,7 +344,7 @@ class VLAN(models.Model): verbose_name_plural = 'VLANs' def __unicode__(self): - return "{0} ({1})".format(self.vid, self.name) + return "VLAN {}".format(self.vid) def get_absolute_url(self): return reverse('ipam:vlan', args=[self.pk]) @@ -358,5 +358,9 @@ class VLAN(models.Model): self.role.name if self.role else '', ]) + @property + def display_name(self): + return "{} ({})".format(self.vid, self.name) + def get_status_class(self): return STATUS_CHOICE_CLASSES[self.status] diff --git a/netbox/templates/ipam/prefix.html b/netbox/templates/ipam/prefix.html index d76416695..d2f3c2e24 100644 --- a/netbox/templates/ipam/prefix.html +++ b/netbox/templates/ipam/prefix.html @@ -50,7 +50,7 @@ VLAN {% if prefix.vlan %} - {{ prefix.vlan.name }} ({{ prefix.vlan.vid }}) + {{ prefix.vlan.display_name }} {% else %} Not assigned {% endif %} diff --git a/netbox/templates/ipam/vlan.html b/netbox/templates/ipam/vlan.html index 35ec1f6d2..5db0efd10 100644 --- a/netbox/templates/ipam/vlan.html +++ b/netbox/templates/ipam/vlan.html @@ -1,7 +1,7 @@ {% extends '_base.html' %} {% load render_table from django_tables2 %} -{% block title %}VLAN {{ vlan }}{% endblock %} +{% block title %}VLAN {{ vlan.display_name }}{% endblock %} {% block content %}
@@ -55,6 +55,10 @@ VLAN ID {{ vlan.vid }} + + Name + {{ vlan.name }} + Status @@ -85,7 +89,7 @@ {{ p.site }} {% endif %} - {{ p.status }} + {{ p.get_status_display }} {{ p.role }} {% endfor %}