mirror/netbox-community-netbox
1
0
Fork 0
mirror of https://github.com/netbox-community/netbox.git synced 2024-05-10 07:54:54 +00:00
Code Activity

Use assertHttpStatus() when evaluating HTTP response status

Browse Source
This commit is contained in:
Jeremy Stretch
2020-01-16 10:47:45 -05:00
parent c0f1910493
commit fecbb60c36
2 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
netbox/ipam/tests/test_api.py
View File

@ -1009,8 +1009,7 @@ class VLANTest(APITestCase):
url = reverse('ipam-api:vlan-detail', kwargs={'pk': self.vlan1.pk})
response = self.client.delete(url, **self.header)
# can't use assertHttpStatus here because we don't have response.data
self.assertEqual(response.status_code, 409)
self.assertHttpStatus(response, status.HTTP_409_CONFLICT)
content = json.loads(response.content.decode('utf-8'))
self.assertIn('detail', content)

2
netbox/utilities/testing.py
View File

@ -20,7 +20,7 @@ class APITestCase(_APITestCase):
"""
err_message = "Expected HTTP status {}; received {}: {}"
self.assertEqual(response.status_code, expected_status, err_message.format(
expected_status, response.status_code, response.data
expected_status, response.status_code, getattr(response, 'data', 'No data')
))