1
0
mirror of https://github.com/netsampler/goflow2.git synced 2024-05-06 15:54:52 +00:00
Vincent Bernat 95945d3042 style: defer unlock when possible/not trivial
Defer unlocking just after taking a lock when possible (when unlock is
done at the very end) and when not trivial (the function body is more
than a couple of lines). This simplifies a bit some functions (no need
to unlock before each return) and for the other, it may avoid a bug in
the future in case a return is inserted into the body of a function.

Use of defer has been optimized a lot in Go and it is believed that
simpler defers have zero overhead since Go 1.14:
https://golang.org/doc/go1.14#runtime

> This release improves the performance of most uses of defer to incur
> almost zero overhead compared to calling the deferred function
> directly. As a result, defer can now be used in performance-critical
> code without overhead concerns.
2021-09-23 10:01:24 +02:00

65 lines
1.2 KiB
Go

package format
import (
"context"
"fmt"
"sync"
)
var (
formatDrivers = make(map[string]FormatDriver)
lock = &sync.RWMutex{}
)
type FormatDriver interface {
Prepare() error // Prepare driver (eg: flag registration)
Init(context.Context) error // Initialize driver (eg: parse keying)
Format(data interface{}) ([]byte, []byte, error) // Send a message
}
type FormatInterface interface {
Format(data interface{}) ([]byte, []byte, error)
}
type Format struct {
driver FormatDriver
}
func (t *Format) Format(data interface{}) ([]byte, []byte, error) {
return t.driver.Format(data)
}
func RegisterFormatDriver(name string, t FormatDriver) {
lock.Lock()
formatDrivers[name] = t
lock.Unlock()
if err := t.Prepare(); err != nil {
panic(err)
}
}
func FindFormat(ctx context.Context, name string) (*Format, error) {
lock.RLock()
t, ok := formatDrivers[name]
lock.RUnlock()
if !ok {
return nil, fmt.Errorf("Format %s not found", name)
}
err := t.Init(ctx)
return &Format{t}, err
}
func GetFormats() []string {
lock.RLock()
defer lock.RUnlock()
t := make([]string, len(formatDrivers))
var i int
for k, _ := range formatDrivers {
t[i] = k
i++
}
return t
}