added test coverage for monitorROAS

package.json

@@ -14,7 +14,7 @@
     "test-reports": "./node_modules/.bin/mocha --exit tests/reports_tests/*.js --require @babel/register",
     "test-proxy": "./node_modules/.bin/mocha --exit tests/proxy_tests/*.js --require @babel/register",
     "test-generate": "./node_modules/.bin/mocha --exit tests/generate_tests/*.js --require @babel/register",
-    "test-rpki": "./node_modules/.bin/mocha --exit tests/rpki_tests/tests.default.js --require @babel/register && ./node_modules/.bin/mocha --exit tests/rpki_tests/tests.external.js --require @babel/register && ./node_modules/.bin/mocha --exit tests/rpki_tests/tests.external-removed.js --require @babel/register",
+    "test-rpki": "./node_modules/.bin/mocha --exit tests/rpki_tests/tests.default.js --require @babel/register && ./node_modules/.bin/mocha --exit tests/rpki_tests/tests.external.js --require @babel/register && ./node_modules/.bin/mocha --exit tests/rpki_tests/tests.external-removed.js --require @babel/register && ./node_modules/.bin/mocha --exit tests/rpki_tests/tests.external-roas.js --require @babel/register",
     "build": "./build.sh",
     "watch-and-serve": "nodemon -e yml,js,json,txt --inspect --exec babel-node index.js",
     "serve": "babel-node index.js",

tests/rpki_tests/config.rpki.test.external-roas.yml

@@ -0,0 +1,43 @@
+environment: test
+
+connectors:
+  - file: connectorTest
+    name: tes
+    params:
+      testType: withdrawal
+
+monitors:
+  - file: monitorROAS
+    channel: rpki
+    name: rpki-monitor
+
+
+# The file containing the monitored prefixes. Please see monitored_prefixes_test.yml for an example
+# This is an array (use new lines and dashes!)
+monitoredPrefixesFiles:
+  - tests/prefixes.test.yml
+
+logging:
+  directory: logs
+  logRotatePattern: YYYY-MM-DD # Whenever the pattern changes, a new file is created and the old one rotated
+  backlogSize: 1
+  maxRetainedFiles: 10
+  maxFileSizeMB: 15
+  compressOnRotation: true
+
+checkForUpdatesAtBoot: false
+persistStatus: false
+
+rpki:
+  preCacheROAs: true
+  refreshVrpListMinutes: 15
+  vrpFile: tests/rpki_tests/roas.json
+
+
+notificationIntervalSeconds: 1800 # Repeat the same alert (which keeps being triggered) after x seconds
+alertOnlyOnce: false
+fadeOffSeconds: 10
+checkFadeOffGroupsSeconds: 2
+pidFile: bgpalerter.pid
+multiProcess: false
+maxMessagesPerSecond: 6000

tests/rpki_tests/roas.after.json

@@ -0,0 +1,12 @@
+[
+  {
+    "asn": "2914",
+    "prefix": "1.2.3.0/24",
+    "maxLength": 24
+  },
+  {
+    "asn": 2914,
+    "prefix": "2001:db8:123::/48",
+    "maxLength": 48
+  }
+]

tests/rpki_tests/roas.before.json

@@ -0,0 +1,17 @@
+[
+  {
+    "asn": "2914",
+    "prefix": "1.2.3.0/24",
+    "maxLength": 24
+  },
+  {
+    "asn": "AS2914",
+    "prefix": "2.3.4.0/24",
+    "maxLength": 24
+  },
+  {
+    "asn": 2914,
+    "prefix": "2001:db8:123::/48",
+    "maxLength": 48
+  }
+]

tests/rpki_tests/roas.json

@@ -0,0 +1,12 @@
+[
+  {
+    "asn": "2914",
+    "prefix": "1.2.3.0/24",
+    "maxLength": 24
+  },
+  {
+    "asn": 2914,
+    "prefix": "2001:db8:123::/48",
+    "maxLength": 48
+  }
+]

tests/rpki_tests/tests.external-roas.js

@@ -0,0 +1,102 @@
+/*
+ * 	BSD 3-Clause License
+ *
+ * Copyright (c) 2019, NTT Ltd.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ *  Redistributions of source code must retain the above copyright notice, this
+ *   list of conditions and the following disclaimer.
+ *
+ *  Redistributions in binary form must reproduce the above copyright notice,
+ *   this list of conditions and the following disclaimer in the documentation
+ *   and/or other materials provided with the distribution.
+ *
+ *  Neither the name of the copyright holder nor the names of its
+ *   contributors may be used to endorse or promote products derived from
+ *   this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+ * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+const chai = require("chai");
+const chaiSubset = require('chai-subset');
+const fs = require('fs');
+const expect = chai.expect;
+const asyncTimeout = 200000;
+chai.use(chaiSubset);
+
+global.EXTERNAL_CONFIG_FILE = "tests/rpki_tests/config.rpki.test.external-roas.yml";
+
+//Test rpki watch file reloading
+fs.copyFileSync("tests/rpki_tests/roas.before.json", "tests/rpki_tests/roas.json");
+
+setTimeout(() => {
+    //Test rpki watch file reloading
+    fs.copyFileSync("tests/rpki_tests/roas.after.json", "tests/rpki_tests/roas.json");
+}, 40000);
+
+const worker = require("../../index");
+const pubSub = worker.pubSub;
+
+describe("RPKI monitoring 4", function() {
+
+    it("ROA diff - external connector", function (done) {
+
+        const expectedData = {
+
+            "d6580b7dbaac973af25585b5a6e7bddc": {
+                id: 'd6580b7dbaac973af25585b5a6e7bddc',
+                truncated: false,
+                origin: 'rpki-monitor',
+                affected: 2914,
+                message: 'ROAs change detected: removed <2.3.4.0/24, 2914, 24, >'
+            }
+
+        };
+
+        let rpkiTestCompletedExternal = false;
+        pubSub.subscribe("rpki", function (type, message) {
+
+            if (!rpkiTestCompletedExternal) {
+                message = JSON.parse(JSON.stringify(message));
+                const id = message.id;
+
+                expect(Object.keys(expectedData).includes(id)).to.equal(true);
+                expect(expectedData[id] != null).to.equal(true);
+
+                expect(message).to.containSubset(expectedData[id]);
+
+                expect(message).to.contain
+                    .keys([
+                        "latest",
+                        "earliest"
+                    ]);
+
+                delete expectedData[id];
+                if (Object.keys(expectedData).length === 0) {
+                    setTimeout(() => {
+                        rpkiTestCompletedExternal = true;
+                        done();
+                    }, 80000);
+                }
+            }
+        });
+
+        setTimeout(() => { // Wait that the watcher realizes the file changed
+            pubSub.publish("test-type", "rpki");
+        }, 100000);
+
+    }).timeout(asyncTimeout);
+});