v1.26.0 release hotfix (#295)

* updated development dependencies to bump lodash version to 4.17.19

* updated rpki-validator version

* update rpki-validator to support external vrps

* improved stability of monitorRPKI, increased test coverage

tests/rpki_tests/config.rpki.test.default.yml

@@ -0,0 +1,43 @@
+environment: test
+
+connectors:
+  - file: connectorTest
+    name: tes
+    params:
+      testType: withdrawal
+
+monitors:
+  - file: monitorRPKI
+    channel: rpki
+    name: rpki-monitor
+    params:
+      thresholdMinPeers: 1
+      preCacheROAs: true
+      refreshVrpListMinutes: 15
+      checkUncovered: true
+
+
+# The file containing the monitored prefixes. Please see monitored_prefixes_test.yml for an example
+# This is an array (use new lines and dashes!)
+monitoredPrefixesFiles:
+  - tests/prefixes.test.yml
+
+logging:
+  directory: logs
+  logRotatePattern: YYYY-MM-DD # Whenever the pattern changes, a new file is created and the old one rotated
+  backlogSize: 1
+  maxRetainedFiles: 10
+  maxFileSizeMB: 15
+  compressOnRotation: true
+
+checkForUpdatesAtBoot: false
+persistStatus: false
+
+
+notificationIntervalSeconds: 1800 # Repeat the same alert (which keeps being triggered) after x seconds
+alertOnlyOnce: false
+fadeOffSeconds: 10
+checkFadeOffGroupsSeconds: 2
+pidFile: bgpalerter.pid
+multiProcess: false
+maxMessagesPerSecond: 6000

tests/rpki_tests/config.rpki.test.external.yml

@@ -0,0 +1,44 @@
+environment: test
+
+connectors:
+  - file: connectorTest
+    name: tes
+    params:
+      testType: withdrawal
+
+monitors:
+  - file: monitorRPKI
+    channel: rpki
+    name: rpki-monitor
+    params:
+      thresholdMinPeers: 1
+      preCacheROAs: true
+      vrpFile: tests/rpki_tests/vrp.json
+      refreshVrpListMinutes: 15
+      checkUncovered: true
+
+
+# The file containing the monitored prefixes. Please see monitored_prefixes_test.yml for an example
+# This is an array (use new lines and dashes!)
+monitoredPrefixesFiles:
+  - tests/prefixes.test.yml
+
+logging:
+  directory: logs
+  logRotatePattern: YYYY-MM-DD # Whenever the pattern changes, a new file is created and the old one rotated
+  backlogSize: 1
+  maxRetainedFiles: 10
+  maxFileSizeMB: 15
+  compressOnRotation: true
+
+checkForUpdatesAtBoot: false
+persistStatus: false
+
+
+notificationIntervalSeconds: 1800 # Repeat the same alert (which keeps being triggered) after x seconds
+alertOnlyOnce: false
+fadeOffSeconds: 10
+checkFadeOffGroupsSeconds: 2
+pidFile: bgpalerter.pid
+multiProcess: false
+maxMessagesPerSecond: 6000

tests/rpki_tests/tests.default.js

@@ -0,0 +1,98 @@
+/*
+ * 	BSD 3-Clause License
+ *
+ * Copyright (c) 2019, NTT Ltd.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ *  Redistributions of source code must retain the above copyright notice, this
+ *   list of conditions and the following disclaimer.
+ *
+ *  Redistributions in binary form must reproduce the above copyright notice,
+ *   this list of conditions and the following disclaimer in the documentation
+ *   and/or other materials provided with the distribution.
+ *
+ *  Neither the name of the copyright holder nor the names of its
+ *   contributors may be used to endorse or promote products derived from
+ *   this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+ * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+const chai = require("chai");
+const chaiSubset = require('chai-subset');
+const expect = chai.expect;
+const asyncTimeout = 200000;
+chai.use(chaiSubset);
+
+global.EXTERNAL_CONFIG_FILE = "tests/rpki_tests/config.rpki.test.default.yml";
+const worker = require("../../index");
+const pubSub = worker.pubSub;
+
+describe("RPKI monitoring 1", function() {
+
+    it("default connector", function (done) {
+
+        const expectedData = {
+
+            "a103_21_244_0_24-13335-false": {
+                id:  "a103_21_244_0_24-13335-false",
+                origin: 'rpki-monitor',
+                affected: '103.21.244.0/24',
+                message: 'The route 103.21.244.0/24 announced by AS13335 is not RPKI valid. Accepted with AS path: [1,2,3,4321,13335]. Valid ROAs: 103.21.244.0/23|AS0|maxLength:23',
+            },
+
+            "a8_8_8_8_22-2914-": {
+                id:  "a8_8_8_8_22-2914-",
+                origin: 'rpki-monitor',
+                affected: '8.8.8.8/22',
+                message: 'The route 8.8.8.8/22 announced by AS2914 is not covered by a ROA. Accepted with AS path: [1,2,3,4321,5060,2914]',
+            }
+        };
+
+        let rpkiTestCompleted = false;
+        pubSub.subscribe("rpki", function (type, message) {
+
+            if (!rpkiTestCompleted) {
+                message = JSON.parse(JSON.stringify(message));
+                const id = message.id;
+
+                expect(Object.keys(expectedData).includes(id)).to.equal(true);
+                expect(expectedData[id] != null).to.equal(true);
+
+                expect(message).to
+                    .containSubset(expectedData[id]);
+
+                expect(message).to.contain
+                    .keys([
+                        "latest",
+                        "earliest"
+                    ]);
+
+                delete expectedData[id];
+                if (Object.keys(expectedData).length === 0) {
+                    setTimeout(() => {
+                        rpkiTestCompleted = true;
+                        done();
+                    }, 5000);
+                }
+            }
+        });
+
+        pubSub.publish("test-type", "rpki");
+
+
+    }).timeout(asyncTimeout);
+
+});

tests/rpki_tests/tests.external.js

@@ -0,0 +1,90 @@
+/*
+ * 	BSD 3-Clause License
+ *
+ * Copyright (c) 2019, NTT Ltd.
+ * All rights reserved.
+ *
+ * Redistribution and use in source and binary forms, with or without
+ * modification, are permitted provided that the following conditions are met:
+ *
+ *  Redistributions of source code must retain the above copyright notice, this
+ *   list of conditions and the following disclaimer.
+ *
+ *  Redistributions in binary form must reproduce the above copyright notice,
+ *   this list of conditions and the following disclaimer in the documentation
+ *   and/or other materials provided with the distribution.
+ *
+ *  Neither the name of the copyright holder nor the names of its
+ *   contributors may be used to endorse or promote products derived from
+ *   this software without specific prior written permission.
+ *
+ * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+ * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+ * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+ * DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE
+ * FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+ * DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+ * SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+ * CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+ * OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+ * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
+ */
+
+const chai = require("chai");
+const chaiSubset = require('chai-subset');
+const expect = chai.expect;
+const asyncTimeout = 200000;
+chai.use(chaiSubset);
+
+global.EXTERNAL_CONFIG_FILE = "tests/rpki_tests/config.rpki.test.external.yml";
+const worker = require("../../index");
+const pubSub = worker.pubSub;
+
+describe("RPKI monitoring 2", function() {
+
+    it("external connector", function (done) {
+
+        const expectedData = {
+
+            "a82_112_100_0_24-2914-false" : {
+                id: 'a82_112_100_0_24-2914-false',
+                origin: 'rpki-monitor',
+                affected: '82.112.100.0/24',
+                message: 'The route 82.112.100.0/24 announced by AS2914 is not RPKI valid. Accepted with AS path: [1,2,3,4321,2914]. Valid ROAs: 82.112.100.0/24|AS1234|maxLength:24'
+            }
+        };
+
+        let rpkiTestCompletedExternal = false;
+        pubSub.subscribe("rpki", function (type, message) {
+
+            if (!rpkiTestCompletedExternal) {
+                message = JSON.parse(JSON.stringify(message));
+                const id = message.id;
+
+                expect(Object.keys(expectedData).includes(id)).to.equal(true);
+                expect(expectedData[id] != null).to.equal(true);
+
+                expect(message).to
+                    .containSubset(expectedData[id]);
+
+                expect(message).to.contain
+                    .keys([
+                        "latest",
+                        "earliest"
+                    ]);
+
+                delete expectedData[id];
+                if (Object.keys(expectedData).length === 0) {
+                    setTimeout(() => {
+                        rpkiTestCompletedExternal = true;
+                        done();
+                    }, 5000);
+                }
+            }
+        });
+
+        pubSub.publish("test-type", "rpki");
+
+
+    }).timeout(asyncTimeout);
+});

tests/rpki_tests/vrp.json

@@ -0,0 +1,17 @@
+[
+  {
+    "asn": "13335",
+    "prefix": "103.21.244.0/24",
+    "maxLength": 24
+  },
+  {
+    "asn": "AS2914",
+    "prefix": "8.8.8.0/22",
+    "maxLength": 24
+  },
+  {
+    "asn": 1234,
+    "prefix": "82.112.100.0/24",
+    "maxLength": 24
+  }
+]