From 553e7e9b18088e184759991c72b756b2c9bcf7d7 Mon Sep 17 00:00:00 2001
From: Hannes Gredler <hannes@rtbrick.com>
Date: Thu, 20 Jan 2022 09:54:18 +0000
Subject: [PATCH] use less expensive strncpy() rather than snprintf() for
 formatting a timer name

---
 src/bbl_timer.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/bbl_timer.c b/src/bbl_timer.c
index c4999399..8b5a296c 100644
--- a/src/bbl_timer.c
+++ b/src/bbl_timer.c
@@ -420,10 +420,10 @@ timer_add (timer_root_s *root,
         timer_requeue(timer, sec, nsec);
         /*
          * Update data and cb if there was a change.
-         * Do the reformatting of name only during a change due to snprintf() being expensive.
+         * Do the reformatting of name only during a change.
          */
         if (timer->data != data || timer->cb != cb) {
-            snprintf(timer->name, sizeof(timer->name), "%s", name);
+            strncpy(timer->name, name, sizeof(timer->name));
             timer->data = data;
             timer->cb = cb;
         }
@@ -444,7 +444,7 @@ timer_add (timer_root_s *root,
         timer = CIRCLEQ_FIRST(&root->timer_gc_qhead);
         CIRCLEQ_REMOVE(&root->timer_gc_qhead, timer, timer_qnode);
         root->gc--;
-	    memset(timer, 0, sizeof(timer_s));
+	memset(timer, 0, sizeof(timer_s));
     }
 
     if (!timer) {
@@ -454,7 +454,7 @@ timer_add (timer_root_s *root,
     /*
      * Store name, data, callback and misc. data.
      */
-    snprintf(timer->name, sizeof(timer->name), "%s", name);
+    strncpy(timer->name, name, sizeof(timer->name));
     timer->data = data;
     timer->cb = cb;
     timer_set_expire(timer, sec, nsec);
@@ -736,4 +736,4 @@ timer_test (void *ctx)
     timer_smear_bucket(&root, 10, 0);
 
     timer_walk(&root);
-}
\ No newline at end of file
+}