diff --git a/providers/azuredns/azureDnsProvider.go b/providers/azuredns/azureDnsProvider.go index 5e93eb598..ce5657f27 100644 --- a/providers/azuredns/azureDnsProvider.go +++ b/providers/azuredns/azureDnsProvider.go @@ -131,9 +131,7 @@ func (a *azurednsProvider) GetNameservers(domain string) ([]*models.Nameserver, var nss []string if zone.ZoneProperties != nil { - for _, ns := range *zone.ZoneProperties.NameServers { - nss = append(nss, ns) - } + nss = append(nss, *zone.ZoneProperties.NameServers...) } return models.ToNameserversStripTD(nss) } diff --git a/providers/bind/bindProvider.go b/providers/bind/bindProvider.go index 3fff119bf..761558936 100644 --- a/providers/bind/bindProvider.go +++ b/providers/bind/bindProvider.go @@ -175,9 +175,6 @@ func (c *bindProvider) GetZoneRecords(domain string) (models.Records, error) { if err != nil { return nil, err } - // FIXME(tlim): Empty branch? Is the intention to skip SOAs? - if rec.Type == "SOA" { - } foundRecords = append(foundRecords, &rec) } diff --git a/providers/gcloud/gcloudProvider.go b/providers/gcloud/gcloudProvider.go index a2cf4a921..f1b04e155 100644 --- a/providers/gcloud/gcloudProvider.go +++ b/providers/gcloud/gcloudProvider.go @@ -135,7 +135,7 @@ func (g *gcloudProvider) GetNameservers(domain string) ([]*models.Nameserver, er return nil, err } if zone == nil { - return nil, fmt.Errorf("Domain %q not found in your GCLOUD account", domain) + return nil, fmt.Errorf("domain %q not found in your GCLOUD account", domain) } return models.ToNameserversStripTD(zone.NameServers) } diff --git a/providers/hetzner/api.go b/providers/hetzner/api.go index 3ce7661f2..5be3ebc37 100644 --- a/providers/hetzner/api.go +++ b/providers/hetzner/api.go @@ -220,7 +220,7 @@ func (api *hetznerProvider) request(endpoint string, method string, request inte cleanupResponseBody := func() { err := resp.Body.Close() if err != nil { - fmt.Println(fmt.Sprintf("failed closing response body: %q", err)) + fmt.Printf("failed closing response body: %q\n", err) } } diff --git a/providers/route53/route53Provider.go b/providers/route53/route53Provider.go index cebd39edf..adf048fd0 100644 --- a/providers/route53/route53Provider.go +++ b/providers/route53/route53Provider.go @@ -521,10 +521,7 @@ func getZoneID(zone r53Types.HostedZone, r *models.RecordConfig) string { /** Removes "/hostedzone/"" prefix from AWS ZoneId */ func parseZoneId(zoneID string) string { - if strings.HasPrefix(zoneID, "/hostedzone/") { - zoneID = strings.TrimPrefix(zoneID, "/hostedzone/") - } - return zoneID + return strings.TrimPrefix(zoneID, "/hostedzone/") } func (r *route53Provider) GetRegistrarCorrections(dc *models.DomainConfig) ([]*models.Correction, error) { diff --git a/providers/vultr/vultrProvider.go b/providers/vultr/vultrProvider.go index d5a930981..7cdb91e31 100644 --- a/providers/vultr/vultrProvider.go +++ b/providers/vultr/vultrProvider.go @@ -225,9 +225,7 @@ func toVultrRecord(dc *models.DomainConfig, rc *models.RecordConfig, vultrID int data := rc.GetTargetField() // Vultr does not use a period suffix for CNAME, NS, or MX. - if strings.HasSuffix(data, ".") { - data = data[:len(data)-1] - } + data = strings.TrimSuffix(data, ".") var priority *int