mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Remove test for empty TXT strings. (#633)

Browse Source
This commit is contained in:
Tom Limoncelli
2020-02-18 15:24:04 -05:00
committed by GitHub
parent f12d4bb8d6
commit 05cedab5a7
1 changed files with 12 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
integrationTest/integration_test.go
View File

@@ -565,12 +565,18 @@ func makeTests(t *testing.T) []*TestCase {
tc("Create a 255-byte TXT", txt("foo", "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA")), tc("Create a 255-byte TXT", txt("foo", "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA")),
) )
// TXT (empty) // FUTURE(tal): https://github.com/StackExchange/dnscontrol/issues/598
if *providerToRun != "CLOUDFLAREAPI" { // We decided that handling an empty TXT string is not a
tests = append(tests, tc("Empty"), // requirement. In the future we might make it a "capability" to
tc("TXT with empty str", txt("foo1", "")), // indicate which vendors fully support RFC 1035, which requires
) // that a TXT string can be empty.
} //
// // TXT (empty)
// if (provider supports empty txt strings) {
// tests = append(tests, tc("Empty"),
// tc("TXT with empty str", txt("foo1", "")),
// )
// }
// TXTMulti // TXTMulti
if !providers.ProviderHasCapability(*providerToRun, providers.CanUseTXTMulti) { if !providers.ProviderHasCapability(*providerToRun, providers.CanUseTXTMulti) {