From 14ae3732b629600f396e2c465f7d06c17ace2884 Mon Sep 17 00:00:00 2001 From: Amelia Aronsohn Date: Fri, 8 Jul 2022 22:14:04 -0700 Subject: [PATCH] DNSIMPLE: do not support spaces in CAA records. (#1606) DNSimple does not support spaces in the records at this time. I have opened an internal ticket on the issue. Fixes test breakage caused in #1377 Co-authored-by: Tom Limoncelli --- docs/_providers/dnsimple.md | 16 ++++++++++++++++ integrationTest/integration_test.go | 2 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/docs/_providers/dnsimple.md b/docs/_providers/dnsimple.md index 82058fd3e..4a874baa5 100644 --- a/docs/_providers/dnsimple.md +++ b/docs/_providers/dnsimple.md @@ -38,3 +38,19 @@ D("example.tld", REG_DNSIMPLE, DnsProvider(DSP_DNSIMPLE), ## Activation DNSControl depends on a DNSimple account access token. + +## Caveats + +### CAA + +As of July 2022, the DNSimple DNS does not accept spaces in CAA records. Putting spaces in the record will result in a 400 Validation Failed error. + +``` +0 issue "letsencrypt.org; validationmethods=dns-01; accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234" +``` + +Removing the spaces will work. +``` +0 issue "letsencrypt.org;validationmethods=dns-01;accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234" +``` + diff --git a/integrationTest/integration_test.go b/integrationTest/integration_test.go index 94dfc573d..de65599a4 100644 --- a/integrationTest/integration_test.go +++ b/integrationTest/integration_test.go @@ -1107,7 +1107,7 @@ func makeTests(t *testing.T) []*TestGroup { tc("CAA many records", caa("@", "issuewild", 0, ";")), ), testgroup("CAA Issue 1374", - requires(providers.CanUseCAA), not("DIGITALOCEAN", "HETZNER"), + requires(providers.CanUseCAA), not("DIGITALOCEAN", "DNSIMPLE", "HETZNER"), // Test support of spaces in the 3rd field. tc("CAA spaces", caa("@", "issue", 0, "letsencrypt.org; validationmethods=dns-01; accounturi=https://acme-v02.api.letsencrypt.org/acme/acct/1234")), ),