mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Remove unused t parameter in setupTestShellCompletionCommand

Browse Source
This commit is contained in:
Tom Limoncelli
2024-03-03 10:25:45 -05:00
parent dfda97b593
commit 18f7208044
1 changed files with 6 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
commands/completion_test.go
View File

@ -20,7 +20,7 @@ type shellTestDataItem struct {
} }
// setupTestShellCompletionCommand resets the buffers used to capture output and errors from the app. // setupTestShellCompletionCommand resets the buffers used to capture output and errors from the app.
func setupTestShellCompletionCommand(t *testing.T, app *cli.App) func(t *testing.T) { func setupTestShellCompletionCommand(app *cli.App) func(t *testing.T) {
return func(t *testing.T) { return func(t *testing.T) {
app.Writer.(*bytes.Buffer).Reset() app.Writer.(*bytes.Buffer).Reset()
cli.ErrWriter.(*bytes.Buffer).Reset() cli.ErrWriter.(*bytes.Buffer).Reset()
@ -65,7 +65,7 @@ func TestShellCompletionCommand(t *testing.T) {
t.Run("shellArg", func(t *testing.T) { t.Run("shellArg", func(t *testing.T) {
for _, tt := range shellsAndCompletionScripts { for _, tt := range shellsAndCompletionScripts {
t.Run(tt.shellName, func(t *testing.T) { t.Run(tt.shellName, func(t *testing.T) {
tearDownTest := setupTestShellCompletionCommand(t, app) tearDownTest := setupTestShellCompletionCommand(app)
defer tearDownTest(t) defer tearDownTest(t)
err := app.Run([]string{app.Name, "shell-completion", tt.shellName}) err := app.Run([]string{app.Name, "shell-completion", tt.shellName})
@ -90,7 +90,7 @@ func TestShellCompletionCommand(t *testing.T) {
} }
t.Run(invalidShellTestDataItem.shellName, func(t *testing.T) { t.Run(invalidShellTestDataItem.shellName, func(t *testing.T) {
tearDownTest := setupTestShellCompletionCommand(t, app) tearDownTest := setupTestShellCompletionCommand(app)
defer tearDownTest(t) defer tearDownTest(t)
err := app.Run([]string{app.Name, "shell-completion", "invalid"}) err := app.Run([]string{app.Name, "shell-completion", "invalid"})
@ -116,7 +116,7 @@ func TestShellCompletionCommand(t *testing.T) {
t.Run("$SHELL", func(t *testing.T) { t.Run("$SHELL", func(t *testing.T) {
for _, tt := range shellsAndCompletionScripts { for _, tt := range shellsAndCompletionScripts {
t.Run(tt.shellName, func(t *testing.T) { t.Run(tt.shellName, func(t *testing.T) {
tearDownTest := setupTestShellCompletionCommand(t, app) tearDownTest := setupTestShellCompletionCommand(app)
defer tearDownTest(t) defer tearDownTest(t)
t.Setenv("SHELL", tt.shellPath) t.Setenv("SHELL", tt.shellPath)
@ -143,7 +143,7 @@ func TestShellCompletionCommand(t *testing.T) {
} }
t.Run(invalidShellTestDataItem.shellName, func(t *testing.T) { t.Run(invalidShellTestDataItem.shellName, func(t *testing.T) {
tearDownTest := setupTestShellCompletionCommand(t, app) tearDownTest := setupTestShellCompletionCommand(app)
defer tearDownTest(t) defer tearDownTest(t)
t.Setenv("SHELL", invalidShellTestDataItem.shellPath) t.Setenv("SHELL", invalidShellTestDataItem.shellPath)
@ -189,7 +189,7 @@ func TestShellCompletionCommand(t *testing.T) {
for _, tC := range testCases { for _, tC := range testCases {
t.Run(tC.shellArg, func(t *testing.T) { t.Run(tC.shellArg, func(t *testing.T) {
tearDownTest := setupTestShellCompletionCommand(t, app) tearDownTest := setupTestShellCompletionCommand(app)
defer tearDownTest(t) defer tearDownTest(t)
app.EnableBashCompletion = true app.EnableBashCompletion = true
defer func() { defer func() {