mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

"Target" RecordConfig should not be exported (#1061)

Browse Source 
* Unexport RecordConfig.Target
* Fix tests
* HEDNS: Fix usage of target field to resolve TXT handling (#1067)

Co-authored-by: Robert Blenkinsopp <robert@blenkinsopp.net>
This commit is contained in:
Tom Limoncelli
2021-03-04 18:58:23 -05:00
committed by GitHub
parent 3e5e976766
commit 21e85e6528
22 changed files with 454 additions and 219 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
models/dns_test.go
View File

@@ -9,7 +9,7 @@ func TestRR(t *testing.T) {
Type: "A",
Name: "foo",
NameFQDN: "foo.example.com",
Target: "1.2.3.4",
target: "1.2.3.4",
TTL: 0,
MxPreference: 0,
}
@@ -23,7 +23,7 @@ func TestRR(t *testing.T) {
Type: "CAA",
Name: "@",
NameFQDN: "example.com",
Target: "mailto:test@example.com",
target: "mailto:test@example.com",
TTL: 300,
CaaTag: "iodef",
CaaFlag: 1,
@@ -38,7 +38,7 @@ func TestRR(t *testing.T) {
Type: "TLSA",
Name: "@",
NameFQDN: "_443._tcp.example.com",
Target: "abcdef0123456789",
target: "abcdef0123456789",
TTL: 300,
TlsaUsage: 0,
TlsaSelector: 0,
@@ -53,8 +53,8 @@ func TestRR(t *testing.T) {
func TestDowncase(t *testing.T) {
dc := DomainConfig{Records: Records{
&RecordConfig{Type: "MX", Name: "lower", Target: "targetmx"},
&RecordConfig{Type: "MX", Name: "UPPER", Target: "TARGETMX"},
&RecordConfig{Type: "MX", Name: "lower", target: "targetmx"},
&RecordConfig{Type: "MX", Name: "UPPER", target: "TARGETMX"},
}}
downcase(dc.Records)
if !dc.Records.HasRecordTypeName("MX", "lower") {