mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Make it easier to add new Rtypes. (#169)

Browse Source 
* NEW: docs/adding-new-rtypes.md
* Mark all "if" and "switch" statements with `#rtype_variations`
* Make consistent use of `default: panic()`
This commit is contained in:
Tom Limoncelli
2017-08-04 12:26:29 -07:00
committed by GitHub
parent f214fb4515
commit 2cbabd859b
9 changed files with 213 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
providers/bind/prettyzone.go
View File

@ -39,7 +39,7 @@ func (z *zoneGenData) Less(i, j int) bool {
if rrtypeA != rrtypeB {
return zoneRrtypeLess(rrtypeA, rrtypeB)
}
switch rrtypeA {
switch rrtypeA { // #rtype_variations
case dns.TypeNS, dns.TypeTXT:
// pass through.
case dns.TypeA:
@ -82,6 +82,8 @@ func (z *zoneGenData) Less(i, j int) bool {
}
default:
panic(fmt.Sprintf("zoneGenData Less: unimplemented rtype %v", dns.TypeToString[rrtypeA]))
// We panic so that we quickly find any switch statements
// that have not been updated for a new RR type.
}
return a.String() < b.String()
}