mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

New validation check: Labels should not be FQDNs (#264)

Browse Source
This commit is contained in:
Craig Peterson
2017-11-14 23:13:50 -05:00
committed by Tom Limoncelli
parent 9a44e785ac
commit 2ef1fc42f8
2 changed files with 35 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

40
pkg/normalize/validate_test.go
View File

@@ -10,24 +10,36 @@ import (
func TestCheckLabel(t *testing.T) {
var tests = []struct {
label string
rType string
target string
isError bool
label string
rType string
isError bool
hasSkipMeta bool
}{
{"@", "A", "0.0.0.0", false},
{"@", "A", "foo.tld", true},
{"foo.bar", "A", "0.0.0.0", false},
{"_foo", "SRV", "foo.tld", false},
{"_foo", "TLSA", "foo.tld", false},
{"_foo", "TXT", "foo.tld", false},
{"@", "A", false, false},
{"foo.bar", "A", false, false},
{"_foo", "A", true, false},
{"_foo", "SRV", false, false},
{"_foo", "TLSA", false, false},
{"_foo", "TXT", false, false},
{"test.foo.tld", "A", true, false},
{"test.foo.tld", "A", false, true},
}
for _, test := range tests {
err := checkLabel(test.label, test.rType, test.target)
if err != nil && test.isError {
t.Errorf("%v: Expected error but got none \n", "TestCheckLabel")
}
t.Run(fmt.Sprintf("%s %s", test.label, test.rType), func(t *testing.T) {
meta := map[string]string{}
if test.hasSkipMeta {
meta["skip_fqdn_check"] = "true"
}
err := checkLabel(test.label, test.rType, "foo.tld", meta)
if err != nil && !test.isError {
t.Errorf(" Expected no error but got %s", err)
}
if err == nil && test.isError {
t.Errorf(" Expected error but got none")
}
})
}
}