PERFORMANCE: Refactor auditrecords.go to loop only once #1570 (#1658)

* stash

* Use rejectif idea

* rename

* wip!

* Convert old systems to new

* fixup!

* fix typo

providers/domainnameshop/auditrecords.go

@@ -0,0 +1,10 @@
+package domainnameshop
+
+import "github.com/StackExchange/dnscontrol/v3/models"
+
+// AuditRecords returns a list of errors corresponding to the records
+// that aren't supported by this provider.  If all records are
+// supported, an empty list is returned.
+func AuditRecords(records []*models.RecordConfig) []error {
+	return nil
+}

providers/domainnameshop/domainnameshopProvider.go

@@ -4,7 +4,6 @@ import (
 	"encoding/json"
 	"fmt"
 
-	"github.com/StackExchange/dnscontrol/v3/models"
 	"github.com/StackExchange/dnscontrol/v3/providers"
 )
 
@@ -46,7 +45,7 @@ var features = providers.DocumentationNotes{
 func init() {
 	fns := providers.DspFuncs{
 		Initializer:   newDomainNameShopProvider,
-		RecordAuditor: auditRecords,
+		RecordAuditor: AuditRecords,
 	}
 
 	providers.RegisterDomainServiceProviderType("DOMAINNAMESHOP", fns, features)
@@ -69,10 +68,6 @@ func newDomainNameShopProvider(conf map[string]string, metadata json.RawMessage)
 	return api, nil
 }
 
-func auditRecords(records []*models.RecordConfig) error {
-	return nil
-}
-
 type domainResponse struct {
 	ID          int      `json:"id"`
 	Domain      string   `json:"domain"`