mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

VULTR: AddOrigin is unnecessary (#314) (#896)

Browse Source
This commit is contained in:
Patrick Gaskin
2020-10-08 16:12:38 -04:00
committed by GitHub
parent b6d2ddd04c
commit 38d9f059a7
1 changed files with 1 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
providers/vultr/vultrProvider.go
View File

@ -8,7 +8,6 @@ import (
"strconv" "strconv"
"strings" "strings"
"github.com/miekg/dns/dnsutil"
"github.com/vultr/govultr" "github.com/vultr/govultr"
"github.com/StackExchange/dnscontrol/v3/models" "github.com/StackExchange/dnscontrol/v3/models"
@ -184,8 +183,7 @@ func toRecordConfig(domain string, r *govultr.DNSRecord) (*models.RecordConfig,
if !strings.HasSuffix(data, ".") { if !strings.HasSuffix(data, ".") {
data = data + "." data = data + "."
} }
// FIXME(tlim): the AddOrigin() might be unneeded. Please test. return rc, rc.SetTarget(data)
return rc, rc.SetTarget(dnsutil.AddOrigin(data, origin))
case "CAA": case "CAA":
// Vultr returns CAA records in the format "[flag] [tag] [value]". // Vultr returns CAA records in the format "[flag] [tag] [value]".
return rc, rc.SetTargetCAAString(data) return rc, rc.SetTargetCAAString(data)