mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

GetNameservers is inconsistent across providers (#655)

Browse Source 
* Warn if GetNameservers returns FQDN+dot strings
* Simplify logic that covers for the inconsistency
* Fix azuredns, gcloud, bind, route53
* Clean up cloudflare, digitalocean, dnsimple, gandi_v5, namedotcom
This commit is contained in:
Tom Limoncelli
2020-03-01 10:33:24 -05:00
committed by GitHub
parent ecac8f1c10
commit 3f68215841
14 changed files with 137 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
providers/namedotcom/nameservers.go
View File

@@ -28,7 +28,7 @@ func (n *NameCom) GetNameservers(domain string) ([]*models.Nameserver, error) {
toUse[idx] = matches[0]
}
}
return models.StringsToNameservers(toUse), nil
return models.ToNameservers(toUse)
}
func (n *NameCom) getNameserversRaw(domain string) ([]string, error) {
@@ -55,9 +55,6 @@ func (n *NameCom) GetRegistrarCorrections(dc *models.DomainConfig) ([]*models.Co
expected := []string{}
for _, ns := range dc.Nameservers {
expected = append(expected, ns.Name)
// FIXME(tlim): This should store a FQDN with no trailing ".".
// See pkg/nameservers/nameservers.go for details.
// Bug https://github.com/StackExchange/dnscontrol/issues/491
}
sort.Strings(expected)
expectedNameservers := strings.Join(expected, ",")