From 486851633a6b6595ea82c7b40116f82c67465b1f Mon Sep 17 00:00:00 2001 From: Yannik Sembritzki Date: Thu, 23 Feb 2023 00:56:25 +0530 Subject: [PATCH] HOSTINGDE: Fix modify referencing incorrect record id (fixes #2066) (#2092) Co-authored-by: Yannik Sembritzki --- providers/hostingde/api.go | 4 ++-- providers/hostingde/types.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/providers/hostingde/api.go b/providers/hostingde/api.go index e6d2cf493..d832de7aa 100644 --- a/providers/hostingde/api.go +++ b/providers/hostingde/api.go @@ -137,14 +137,14 @@ func (hp *hostingdeProvider) updateZone(zc *zoneConfig, DnsSecOptions *dnsSecOpt toDelete := []*record{} for _, d := range del { r := recordToNative(d.Existing) - r.ID = d.Existing.Original.(*record).ID + r.ID = d.Existing.Original.(record).ID toDelete = append(toDelete, r) } toModify := []*record{} for _, m := range mod { r := recordToNative(m.Desired) - r.ID = m.Existing.Original.(*record).ID + r.ID = m.Existing.Original.(record).ID toModify = append(toModify, r) } diff --git a/providers/hostingde/types.go b/providers/hostingde/types.go index 24cba942a..b562c69b3 100644 --- a/providers/hostingde/types.go +++ b/providers/hostingde/types.go @@ -138,7 +138,7 @@ type responseData struct { TotalPages uint `json:"totalPages"` } -func (r *record) nativeToRecord(domain string) *models.RecordConfig { +func (r record) nativeToRecord(domain string) *models.RecordConfig { // normalize cname,mx,ns records with dots to be consistent with our config format. if r.Type == "ALIAS" || r.Type == "CNAME" || r.Type == "MX" || r.Type == "NS" || r.Type == "SRV" { if r.Content != "." {