mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Fix GCLOUD txt records

Browse Source
This commit is contained in:
Tom Limoncelli
2023-10-25 13:35:41 -04:00
parent 6565a9694b
commit 4c2ca71b5e
2 changed files with 12 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
providers/azuredns/azureDnsProvider.go
View File

@ -14,6 +14,7 @@ import (
"github.com/StackExchange/dnscontrol/v4/models" "github.com/StackExchange/dnscontrol/v4/models"
"github.com/StackExchange/dnscontrol/v4/pkg/diff2" "github.com/StackExchange/dnscontrol/v4/pkg/diff2"
"github.com/StackExchange/dnscontrol/v4/pkg/printer" "github.com/StackExchange/dnscontrol/v4/pkg/printer"
"github.com/StackExchange/dnscontrol/v4/pkg/txtutil"
"github.com/StackExchange/dnscontrol/v4/providers" "github.com/StackExchange/dnscontrol/v4/providers"
) )
@ -524,7 +525,10 @@ func (a *azurednsProvider) recordToNativeDiff2(recordKey models.RecordKey, recor
// Empty TXT record needs to have no value set in it's properties // Empty TXT record needs to have no value set in it's properties
tt := rec.GetTargetField() tt := rec.GetTargetField()
if tt != "" { if tt != "" {
txts := []*string{to.StringPtr(tt)} var txts []*string
for _, t := range txtutil.ToChunks(tt) {
txts = append(txts, to.StringPtr(t))
}
recordSet.Properties.TxtRecords = append(recordSet.Properties.TxtRecords, &adns.TxtRecord{Value: txts}) recordSet.Properties.TxtRecords = append(recordSet.Properties.TxtRecords, &adns.TxtRecord{Value: txts})
} }
case "MX": case "MX":

8
providers/gcloud/gcloudProvider.go
View File

@ -12,6 +12,7 @@ import (
"github.com/StackExchange/dnscontrol/v4/models" "github.com/StackExchange/dnscontrol/v4/models"
"github.com/StackExchange/dnscontrol/v4/pkg/diff" "github.com/StackExchange/dnscontrol/v4/pkg/diff"
"github.com/StackExchange/dnscontrol/v4/pkg/printer" "github.com/StackExchange/dnscontrol/v4/pkg/printer"
"github.com/StackExchange/dnscontrol/v4/pkg/txtutil"
"github.com/StackExchange/dnscontrol/v4/providers" "github.com/StackExchange/dnscontrol/v4/providers"
gauth "golang.org/x/oauth2/google" gauth "golang.org/x/oauth2/google"
gdns "google.golang.org/api/dns/v1" gdns "google.golang.org/api/dns/v1"
@ -303,7 +304,12 @@ func (g *gcloudProvider) GetZoneRecordsCorrections(dc *models.DomainConfig, exis
} }
for _, r := range dc.Records { for _, r := range dc.Records {
if keyForRec(r) == ck { if keyForRec(r) == ck {
newRRs.Rrdatas = append(newRRs.Rrdatas, r.GetTargetCombined()) if ck.Type == "TXT" {
chunks := txtutil.ToChunks(r.GetTargetField())
newRRs.Rrdatas = append(newRRs.Rrdatas, chunks...)
} else {
newRRs.Rrdatas = append(newRRs.Rrdatas, r.GetTargetCombined())
}
newRRs.Ttl = int64(r.TTL) newRRs.Ttl = int64(r.TTL)
} }
} }