mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Cleanup: Bubble errors up from diff instead of panic (#799) (#817)

Browse Source
This commit is contained in:
Mike Cochrane
2020-08-21 07:49:00 +12:00
committed by GitHub
parent 79357bb667
commit 59747a96f0
27 changed files with 122 additions and 36 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
providers/namecheap/namecheapProvider.go
View File

@@ -178,7 +178,10 @@ func (n *Namecheap) GetDomainCorrections(dc *models.DomainConfig) ([]*models.Cor
models.PostProcessRecords(actual)
differ := diff.New(dc)
_, create, delete, modify := differ.IncrementalDiff(actual)
_, create, delete, modify, err := differ.IncrementalDiff(actual)
if err != nil {
return nil, err
}
// // because namecheap doesn't have selective create, delete, modify,
// // we bundle them all up to send at once. We *do* want to see the