mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

DOCUMENTATION: Document bugid 491 (#492)

Browse Source
This commit is contained in:
Tom Limoncelli
2019-05-20 14:37:23 -04:00
committed by GitHub
parent f795af3be0
commit 5f77888296
2 changed files with 7 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
pkg/nameservers/nameservers.go
View File

@@ -32,6 +32,10 @@ func DetermineNameservers(dc *models.DomainConfig) ([]*models.Nameserver, error)
} }
for i := 0; i < take; i++ { for i := 0; i < take; i++ {
nss[i].Name = strings.TrimRight(nss[i].Name, ".") nss[i].Name = strings.TrimRight(nss[i].Name, ".")
// FIXME(tlim): Rather than correct broken providers, we should print
// a warning that the provider should be updated to store the FQDN
// with no trailing dot. See also providers/namedotcom/nameservers.go
// Bug https://github.com/StackExchange/dnscontrol/issues/491
ns = append(ns, nss[i]) ns = append(ns, nss[i])
} }
} }

3
providers/namedotcom/nameservers.go
View File

@@ -55,6 +55,9 @@ func (n *NameCom) GetRegistrarCorrections(dc *models.DomainConfig) ([]*models.Co
expected := []string{} expected := []string{}
for _, ns := range dc.Nameservers { for _, ns := range dc.Nameservers {
expected = append(expected, ns.Name) expected = append(expected, ns.Name)
// FIXME(tlim): This should store a FQDN with no trailing ".".
// See pkg/nameservers/nameservers.go for details.
// Bug https://github.com/StackExchange/dnscontrol/issues/491
} }
sort.Strings(expected) sort.Strings(expected)
expectedNameservers := strings.Join(expected, ",") expectedNameservers := strings.Join(expected, ",")