From 6ace5e2b4b9a333b7609f5f76f225c04e83fec98 Mon Sep 17 00:00:00 2001 From: Kieran Jacobsen <2404128+kjacobsen@users.noreply.github.com> Date: Tue, 24 Jul 2018 22:51:10 +1000 Subject: [PATCH] Cloudflare: Add support for MX priorities of "" (0) (#374) * Cloudflare: Add support for MX priorities of "" (0) --- providers/cloudflare/cloudflareProvider.go | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/providers/cloudflare/cloudflareProvider.go b/providers/cloudflare/cloudflareProvider.go index 1a4f8927a..6d183723b 100644 --- a/providers/cloudflare/cloudflareProvider.go +++ b/providers/cloudflare/cloudflareProvider.go @@ -385,10 +385,14 @@ func (c *cfRecord) nativeToRecord(domain string) *models.RecordConfig { switch rType := c.Type; rType { // #rtype_variations case "MX": var priority uint16 - if p, err := c.Priority.Int64(); err != nil { - panic(errors.Wrap(err, "error decoding priority from cloudflare record")) + if c.Priority == "" { + priority = 0 } else { - priority = uint16(p) + if p, err := c.Priority.Int64(); err != nil { + panic(errors.Wrap(err, "error decoding priority from cloudflare record")) + } else { + priority = uint16(p) + } } if err := rc.SetTargetMX(priority, c.Content); err != nil { panic(errors.Wrap(err, "unparsable MX record received from cloudflare"))