mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

tests that would have caught tag renaming bug. js tests now don't marahsl expected through the go object. Instead minify both sides to compare

Browse Source
This commit is contained in:
Craig Peterson
2017-07-20 17:41:15 -04:00
parent d106c88488
commit 710d14b1a9
11 changed files with 41 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
pkg/js/js_test.go
View File

@@ -8,7 +8,8 @@ import (
"testing"
"unicode"
"github.com/StackExchange/dnscontrol/models"
"github.com/tdewolff/minify"
minjson "github.com/tdewolff/minify/json"
)
const (
@@ -30,6 +31,8 @@ func TestParsedFiles(t *testing.T) {
if filepath.Ext(f.Name()) != ".js" || !unicode.IsNumber(rune(f.Name()[0])) {
continue
}
m := minify.New()
m.AddFunc("json", minjson.Minify)
t.Run(f.Name(), func(t *testing.T) {
content, err := ioutil.ReadFile(filepath.Join(testDir, f.Name()))
if err != nil {
@@ -43,25 +46,24 @@ func TestParsedFiles(t *testing.T) {
if err != nil {
t.Fatal(err)
}
actualJSON, err = m.Bytes("json", actualJSON)
if err != nil {
t.Fatal(err)
}
expectedFile := filepath.Join(testDir, f.Name()[:len(f.Name())-3]+".json")
expectedData, err := ioutil.ReadFile(expectedFile)
if err != nil {
t.Fatal(err)
}
conf = &models.DNSConfig{}
//unmarshal and remarshal to not require manual formatting
err = json.Unmarshal(expectedData, conf)
if err != nil {
t.Fatal(err)
}
expectedJSON, err := json.MarshalIndent(conf, "", " ")
expectedJSON, err := m.String("json", string(expectedData))
if err != nil {
t.Fatal(err)
}
if string(expectedJSON) != string(actualJSON) {
t.Error("Expected and actual json don't match")
t.Log("Expected:", string(expectedJSON))
t.Log("Actual:", string(actualJSON))
t.Log("Actual :", string(actualJSON))
}
})
}