mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

GCORE: fix TXT record double quoting (#2592)

Browse Source 
Thanks!
This commit is contained in:
Yuhui Xu
2023-10-13 04:36:36 -07:00
committed by GitHub
parent 071fd2b7df
commit 71174551c4
1 changed files with 28 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

29
providers/gcore/convert.go
View File

@ -40,7 +40,12 @@ func nativeToRecords(n gcoreRRSetExtended, zoneName string) ([]*models.RecordCon
return nil, fmt.Errorf("unparsable record received from G-Core: %w", err) return nil, fmt.Errorf("unparsable record received from G-Core: %w", err)
} }
default: // "A", "AAAA", "CAA", "NS", "CNAME", "MX", "PTR", "SRV", "TXT" case "TXT": // Avoid double quoting for TXT records
if err := rc.SetTargetTXTs(convertSdkAnySliceToTxtSlice(value.Content)); err != nil {
return nil, fmt.Errorf("unparsable record received from G-Core: %w", err)
}
default: // "A", "AAAA", "CAA", "NS", "CNAME", "MX", "PTR", "SRV"
if err := rc.PopulateFromString(recType, value.ContentToString(), zoneName); err != nil { if err := rc.PopulateFromString(recType, value.ContentToString(), zoneName); err != nil {
return nil, fmt.Errorf("unparsable record received from G-Core: %w", err) return nil, fmt.Errorf("unparsable record received from G-Core: %w", err)
} }
@ -79,6 +84,12 @@ func recordsToNative(rcs []*models.RecordConfig, expectedKey models.RecordKey) *
Meta: nil, Meta: nil,
Enabled: true, Enabled: true,
} }
case "TXT": // Avoid double quoting for TXT records
rr = dnssdk.ResourceRecord{
Content: convertTxtSliceToSdkAnySlice(r.TxtStrings),
Meta: nil,
Enabled: true,
}
default: default:
rr = dnssdk.ResourceRecord{ rr = dnssdk.ResourceRecord{
Content: dnssdk.ContentFromValue(key.Type, r.GetTargetCombined()), Content: dnssdk.ContentFromValue(key.Type, r.GetTargetCombined()),
@ -107,3 +118,19 @@ func recordsToNative(rcs []*models.RecordConfig, expectedKey models.RecordKey) *
return result return result
} }
func convertTxtSliceToSdkAnySlice(records []string) []any {
result := []any{}
for _, record := range records {
result = append(result, record)
}
return result
}
func convertSdkAnySliceToTxtSlice(records []any) []string {
result := []string{}
for _, record := range records {
result = append(result, record.(string))
}
return result
}