From 7826c23cfa826260942fe99ea19a1f2b9c594071 Mon Sep 17 00:00:00 2001 From: Tom Limoncelli Date: Tue, 14 Jun 2022 07:16:01 -0400 Subject: [PATCH] CSCGLOBAL: Enable CAA records (#1536) * Enable CAA * Another API oddity * Disable debug output --- providers/cscglobal/cscglobalProvider.go | 4 ++-- providers/cscglobal/dns.go | 5 ++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/providers/cscglobal/cscglobalProvider.go b/providers/cscglobal/cscglobalProvider.go index ddf8c199e..d50d07e56 100644 --- a/providers/cscglobal/cscglobalProvider.go +++ b/providers/cscglobal/cscglobalProvider.go @@ -25,8 +25,8 @@ type providerClient struct { } var features = providers.DocumentationNotes{ - providers.CanGetZones: providers.Can(), - //providers.CanUseCAA: providers.Can(), + providers.CanGetZones: providers.Can(), + providers.CanUseCAA: providers.Can(), providers.CanUseSRV: providers.Can(), providers.DocOfficiallySupported: providers.Can(), } diff --git a/providers/cscglobal/dns.go b/providers/cscglobal/dns.go index ba2d5eadc..21929356b 100644 --- a/providers/cscglobal/dns.go +++ b/providers/cscglobal/dns.go @@ -292,10 +292,9 @@ func makeEdit(domainname string, m diff.Correlation) zoneResourceRecordEdit { case "CAA": var tagValue = old.CaaTag zer.CurrentTag = &tagValue - if old.CaaTag != rec.CaaTag { + if old.CaaTag != rec.CaaTag || old.CaaFlag != rec.CaaFlag || old.TTL != rec.TTL { + // If anything changed, we need to update both tag and flag. zer.NewTag = &(rec.CaaTag) - } - if old.CaaFlag != rec.CaaFlag { zer.NewFlag = &(rec.CaaFlag) } case "MX":