mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

MAINTENANCE: Unknown rtypes should return errors, not a panic (#945)

Browse Source 
* Eliminate panics related to unknown rtypes
This commit is contained in:
Tom Limoncelli
2020-11-13 16:32:40 -05:00
committed by GitHub
parent 654bb9cfeb
commit 7db3741bc7
13 changed files with 105 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
providers/cloudns/cloudnsProvider.go
View File

@@ -257,9 +257,7 @@ func toReq(rc *models.RecordConfig) (requestParams, error) {
req["algorithm"] = strconv.Itoa(int(rc.SshfpAlgorithm))
req["fptype"] = strconv.Itoa(int(rc.SshfpFingerprint))
default:
msg := fmt.Sprintf("ClouDNS.toReq rtype %v unimplemented", rc.Type)
panic(msg)
// We panic so that we quickly find any switch statements
return nil, fmt.Errorf("ClouDNS.toReq rtype %q unimplemented", rc.Type)
}
return req, nil