mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

MAINTENANCE: Unknown rtypes should return errors, not a panic (#945)

Browse Source 
* Eliminate panics related to unknown rtypes
This commit is contained in:
Tom Limoncelli
2020-11-13 16:32:40 -05:00
committed by GitHub
parent 654bb9cfeb
commit 7db3741bc7
13 changed files with 105 additions and 70 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
providers/exoscale/exoscaleProvider.go
View File

@@ -103,11 +103,11 @@ func (c *exoscaleProvider) GetDomainCorrections(dc *models.DomainConfig) ([]*mod
rec.SetTarget(r.Content)
case "MX":
if err := rec.SetTargetMX(uint16(r.Prio), r.Content); err != nil {
panic(fmt.Errorf("unparsable record received from exoscale: %w", err))
return nil, fmt.Errorf("unparsable record received from exoscale: %w", err)
}
default:
if err := rec.PopulateFromString(r.RecordType, r.Content, dc.Name); err != nil {
panic(fmt.Errorf("unparsable record received from exoscale: %w", err))
return nil, fmt.Errorf("unparsable record received from exoscale: %w", err)
}
}
existingRecords = append(existingRecords, rec)