mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

gandi works

Browse Source
This commit is contained in:
Tom Limoncelli
2023-11-12 19:52:09 -05:00
parent e112e37818
commit 863db836e2
3 changed files with 10 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
integrationTest/integration_test.go
View File

@ -1089,17 +1089,17 @@ func makeTests(t *testing.T) []*TestGroup {
tc("TXT with 1 double-quotes", txt("foodq", `quo"te`)), tc("TXT with 1 double-quotes", txt("foodq", `quo"te`)),
tc("TXT with 2 double-quotes", txt("foodqs", `q"uo"te`)), tc("TXT with 2 double-quotes", txt("foodqs", `q"uo"te`)),
tc("TXT with 1 backslash", txt("fooosbs", `back\slash`)), tc("TXT with 1 backslash", txt("fooosbs", `back\slash`)),
//clear(),
tc("TXT interior ws", txt("foosp", "with spaces")), tc("TXT interior ws", txt("foosp", "with spaces")),
tc("TXT trailing ws", txt("foows1", "with space at end ")), tc("TXT trailing ws", txt("foows1", "with space at end ")),
//clear(),
//tc("Create a TXT/SPF", txt("foo", "v=spf1 ip4:99.99.99.99 -all")), //tc("Create a TXT/SPF", txt("foo", "v=spf1 ip4:99.99.99.99 -all")),
// This was added because Vultr syntax-checks TXT records with SPF contents. // This was added because Vultr syntax-checks TXT records with SPF contents.
//clear(), //clear(),
// TODO(tlim): Re-add this when we fix the RFC1035 escaped-quotes issue. // TODO(tlim): Re-add this when we fix the RFC1035 escaped-quotes issue.
tc("Create TXT with frequently escaped characters", txt("fooex", `!^.*$@#%^&()([][{}{<></:;-_=+\`)), //tc("Create TXT with frequently escaped characters", txt("fooex", `!^.*$@#%^&()([][{}{<></:;-_=+\`)),
clear(), clear(),
), ),

6
providers/cloudflare/auditrecords.go
View File

@ -11,11 +11,11 @@ import (
func AuditRecords(records []*models.RecordConfig) []error { func AuditRecords(records []*models.RecordConfig) []error {
a := rejectif.Auditor{} a := rejectif.Auditor{}
a.Add("TXT", rejectif.TxtLongerThan255) // Last verified 2022-06-18 //a.Add("TXT", rejectif.TxtLongerThan255) // Last verified 2022-06-18
a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2022-06-18 a.Add("TXT", rejectif.TxtHasTrailingSpace) // Last verified 2023-11-12
a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2022-06-18 a.Add("TXT", rejectif.TxtIsEmpty) // Last verified 2023-11-12
return a.Audit(records) return a.Audit(records)
} }

9
providers/powerdns/convert_test.go
View File

@ -17,20 +17,21 @@ func TestToRecordConfig(t *testing.T) {
assert.NoError(t, err) assert.NoError(t, err)
assert.Equal(t, "test.example.com", recordConfig.NameFQDN) assert.Equal(t, "test.example.com", recordConfig.NameFQDN)
assert.Equal(t, "\"simple\"", recordConfig.String()) assert.Equal(t, "simple", recordConfig.GetTargetTXTJoined())
assert.Equal(t, uint32(120), recordConfig.TTL) assert.Equal(t, uint32(120), recordConfig.TTL)
assert.Equal(t, "TXT", recordConfig.Type) assert.Equal(t, "TXT", recordConfig.Type)
largeContent := fmt.Sprintf("\"%s\" \"%s\"", strings.Repeat("A", 300), strings.Repeat("B", 300)) largeContent := fmt.Sprintf(`"%s" "%s"`, strings.Repeat("A", 300), strings.Repeat("B", 300))
largeRecord := zones.Record{ largeRecord := zones.Record{
Content: largeContent, Content: largeContent,
} }
recordConfig, err = toRecordConfig("example.com", largeRecord, 5, "large", "TXT") recordConfig, err = toRecordConfig("example.com", largeRecord, 5, "large", "TXT")
largeJoined := `"` + strings.Repeat("A", 300) + strings.Repeat("B", 300) + `"` //largeJoined := `"` + strings.Repeat("A", 300) + strings.Repeat("B", 300) + `"`
largeJoined := strings.Repeat("A", 300) + strings.Repeat("B", 300)
assert.NoError(t, err) assert.NoError(t, err)
assert.Equal(t, "large.example.com", recordConfig.NameFQDN) assert.Equal(t, "large.example.com", recordConfig.NameFQDN)
assert.Equal(t, largeJoined, recordConfig.String()) assert.Equal(t, largeJoined, recordConfig.GetTargetTXTJoined())
assert.Equal(t, uint32(5), recordConfig.TTL) assert.Equal(t, uint32(5), recordConfig.TTL)
assert.Equal(t, "TXT", recordConfig.Type) assert.Equal(t, "TXT", recordConfig.Type)
} }