mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

MAINT: Make staticcheck more strict and fix new warnings (#1408)

Browse Source 
* Make staticcheck more strict and fix new warnings
This commit is contained in:
Tom Limoncelli
2022-02-11 14:30:45 -05:00
committed by GitHub
parent 25d72395f3
commit 886dbf6d00
16 changed files with 117 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
pkg/acme/acme.go
View File

@@ -181,7 +181,11 @@ func getCertInfo(pemBytes []byte) (names []string, remaining float64, err error)
if err != nil {
return nil, 0, err
}
// FIXME(tlim): should use time.Until instead of t.Sub(time.Now()) (S1024)
//lint:ignore S1024 Fixing this without unit tests scares me.
// TODO(tlim): I think the fix is the line below but since this code
// may be decommed eventually, and since there are no unit tests,
// I'm not excited about making this change.
// var daysLeft = float64(time.Until(cert.NotAfter)) / float64(time.Hour*24)
var daysLeft = float64(cert.NotAfter.Sub(time.Now())) / float64(time.Hour*24)
return cert.DNSNames, daysLeft, nil
}