From 9eda756a1be3e96546106bad12c489ead565eb2b Mon Sep 17 00:00:00 2001 From: Tom Limoncelli Date: Mon, 15 Aug 2022 10:14:10 -0400 Subject: [PATCH] CHORE: Update AZUREDNS deps, (#1706) * Update AZURE_DNS deps * CHORE: Reduce test runtime for AZURE_DNS,GANDI_V5,CLOUDFLAREAPI --- go.mod | 2 +- go.sum | 4 ++-- integrationTest/integration_test.go | 28 ++++++++++++++++++++++++++-- 3 files changed, 29 insertions(+), 5 deletions(-) diff --git a/go.mod b/go.mod index c14e21353..ae133c773 100644 --- a/go.mod +++ b/go.mod @@ -14,7 +14,7 @@ require ( github.com/akamai/AkamaiOPEN-edgegrid-golang v1.2.1 github.com/andreyvit/diff v0.0.0-20170406064948-c7f18ee00883 github.com/aws/aws-sdk-go-v2 v1.16.11 - github.com/aws/aws-sdk-go-v2/config v1.16.1 + github.com/aws/aws-sdk-go-v2/config v1.17.0 github.com/aws/aws-sdk-go-v2/credentials v1.12.13 github.com/aws/aws-sdk-go-v2/service/route53 v1.21.7 github.com/aws/aws-sdk-go-v2/service/route53domains v1.12.12 diff --git a/go.sum b/go.sum index 41f56117d..5902eaf41 100644 --- a/go.sum +++ b/go.sum @@ -181,6 +181,8 @@ github.com/aws/aws-sdk-go-v2 v1.16.11 h1:xM1ZPSvty3xVmdxiGr7ay/wlqv+MWhH0rMlyLdb github.com/aws/aws-sdk-go-v2 v1.16.11/go.mod h1:WTACcleLz6VZTp7fak4EO5b9Q4foxbn+8PIz3PmyKlo= github.com/aws/aws-sdk-go-v2/config v1.16.1 h1:jasqFPOoNPXHOYGEEuvyT87ACiXhD3OkQckIm5uqi5I= github.com/aws/aws-sdk-go-v2/config v1.16.1/go.mod h1:4SKzBMiB8lV0fw2w7eDBo/LjQyHFITN4vUUuqpurFmI= +github.com/aws/aws-sdk-go-v2/config v1.17.0 h1:e0tIuubcjp0gJQdllgEMwolWWXGK/sKAFd1tS5S6m6I= +github.com/aws/aws-sdk-go-v2/config v1.17.0/go.mod h1:4SKzBMiB8lV0fw2w7eDBo/LjQyHFITN4vUUuqpurFmI= github.com/aws/aws-sdk-go-v2/credentials v1.12.13 h1:cuPzIsjKAWBUAAk8ZUR2l02Sxafl9hiaMsc7tlnjwAY= github.com/aws/aws-sdk-go-v2/credentials v1.12.13/go.mod h1:9fDEemXizwXrxPU1MTzv69LP/9D8HVl5qHAQO9A9ikY= github.com/aws/aws-sdk-go-v2/feature/ec2/imds v1.12.12 h1:wgJBHO58Pc1V1QAnzdVM3JK3WbE/6eUF0JxCZ+/izz0= @@ -1238,8 +1240,6 @@ github.com/ultraware/whitespace v0.0.5 h1:hh+/cpIcopyMYbZNVov9iSxvJU3OYQg78Sfaqz github.com/ultraware/whitespace v0.0.5/go.mod h1:aVMh/gQve5Maj9hQ/hg+F75lr/X5A89uZnzAmWSineA= github.com/urfave/cli v1.20.0/go.mod h1:70zkFmudgCuE/ngEzBv17Jvp/497gISqfk5gWijbERA= github.com/urfave/cli v1.22.1/go.mod h1:Gos4lmkARVdJ6EkW0WaNv/tZAAMe9V7XWyB60NtXRu0= -github.com/urfave/cli/v2 v2.11.1 h1:UKK6SP7fV3eKOefbS87iT9YHefv7iB/53ih6e+GNAsE= -github.com/urfave/cli/v2 v2.11.1/go.mod h1:f8iq5LtQ/bLxafbdBSLPPNsgaW0l/2fYYEHhAyPlwvo= github.com/urfave/cli/v2 v2.11.2 h1:FVfNg4m3vbjbBpLYxW//WjxUoHvJ9TlppXcqY9Q9ZfA= github.com/urfave/cli/v2 v2.11.2/go.mod h1:f8iq5LtQ/bLxafbdBSLPPNsgaW0l/2fYYEHhAyPlwvo= github.com/uudashr/gocognit v1.0.6 h1:2Cgi6MweCsdB6kpcVQp7EW4U23iBFQWfTXiWlyp842Y= diff --git a/integrationTest/integration_test.go b/integrationTest/integration_test.go index b174a3943..d1574f8ca 100644 --- a/integrationTest/integration_test.go +++ b/integrationTest/integration_test.go @@ -854,6 +854,11 @@ func makeTests(t *testing.T) []*TestGroup { // testgroup("gentxt TXT", + not( + "CLOUDFLAREAPI", // Too slow. Add back as needed. + "GANDI_V5", // Too slow. Add back as needed. + "AZURE_DNS", // Too slow. Add back as needed. + ), gentxt("0"), gentxt("1"), gentxt("10"), @@ -867,6 +872,11 @@ func makeTests(t *testing.T) []*TestGroup { ), testgroup("long TXT", + not( + "CLOUDFLAREAPI", // Too slow. Add back as needed. + "GANDI_V5", // Too slow. Add back as needed. + "AZURE_DNS", // Too slow. Add back as needed. + ), tc("Create a 505 TXT", txt("foo257", strings.Repeat("E", 505))), tc("Create a 506 TXT", txt("foo257", strings.Repeat("E", 506))), tc("Create a 507 TXT", txt("foo257", strings.Repeat("E", 507))), @@ -883,6 +893,11 @@ func makeTests(t *testing.T) []*TestGroup { // Test the ability to change TXT records on the DIFFERENT labels accurately. testgroup("TXTMulti", + not( + "CLOUDFLAREAPI", // Too slow. Add back as needed. + "GANDI_V5", // Too slow. Add back as needed. + "AZURE_DNS", // Too slow. Add back as needed. + ), tc("Create TXTMulti 1", txtmulti("foo1", []string{"simple"}), ), @@ -914,6 +929,11 @@ func makeTests(t *testing.T) []*TestGroup { // Test the ability to change TXT records on the SAME labels accurately. testgroup("TXTMulti-same", + not( + "CLOUDFLAREAPI", // Too slow. Add back as needed. + "GANDI_V5", // Too slow. Add back as needed. + "AZURE_DNS", // Too slow. Add back as needed. + ), tc("Create TXTMulti 1", txtmulti("foo", []string{"simple"}), ), @@ -982,6 +1002,7 @@ func makeTests(t *testing.T) []*TestGroup { // - Gandi: page size is 100, therefore we test with 99, 100, and 101 // - DIGITALOCEAN: page size is 100 (default: 20) not( + "AZURE_DNS", // Removed because it is too slow "CLOUDFLAREAPI", // Infinite pagesize but due to slow speed, skipping. "CSCGLOBAL", // Doesn't page. Works fine. Due to the slow API we skip. "GANDI_V5", // Their API is so damn slow. We'll add it back as needed. @@ -996,8 +1017,10 @@ func makeTests(t *testing.T) []*TestGroup { testgroup("pager601", only( - //"AZURE_DNS", // Currently failing. + //"AZURE_DNS", // Removed because it is too slow + //"CLOUDFLAREAPI", // Infinite pagesize but due to slow speed, skipping. //"CSCGLOBAL", // Doesn't page. Works fine. Due to the slow API we skip. + //"GANDI_V5", // Their API is so damn slow. We'll add it back as needed. "GCLOUD", "HEXONET", //"MSDNS", // No paging done. No need to test. @@ -1010,9 +1033,10 @@ func makeTests(t *testing.T) []*TestGroup { testgroup("pager1201", only( //"AKAMAIEDGEDNS", // No paging done. No need to test. - //"AZURE_DNS", // Currently failing. See https://github.com/StackExchange/dnscontrol/issues/770 + //"AZURE_DNS", // Currently failing. See https://github.com/StackExchange/dnscontrol/issues/770 //"CLOUDFLAREAPI", // Fails with >1000 corrections. See https://github.com/StackExchange/dnscontrol/issues/1440 //"CSCGLOBAL", // Doesn't page. Works fine. Due to the slow API we skip. + //"GANDI_V5", // Their API is so damn slow. We'll add it back as needed. "HEXONET", "HOSTINGDE", //"MSDNS", // No paging done. No need to test.