From a5dcad06a378e021268f37a822ae63619f6df946 Mon Sep 17 00:00:00 2001 From: Tom Limoncelli Date: Mon, 27 May 2019 15:10:00 -0400 Subject: [PATCH] Fix integration tests (NAMEDOTCOM, CLOUDFLARE) (#498) NAMEDOTCOM: TXTMulti is broken. Disable. CLOUDFLARE: Fix SSHFP tests. --- integrationTest/integration_test.go | 21 +++++++++++++++------ providers/namedotcom/namedotcomProvider.go | 2 +- 2 files changed, 16 insertions(+), 7 deletions(-) diff --git a/integrationTest/integration_test.go b/integrationTest/integration_test.go index 8d981178b..c3258f413 100644 --- a/integrationTest/integration_test.go +++ b/integrationTest/integration_test.go @@ -465,12 +465,21 @@ func makeTests(t *testing.T) []*TestCase { t.Log("Skipping SSHFP Tests because provider does not support them") } else { tests = append(tests, tc("Empty"), - tc("SSHFP record", sshfp("@", 1, 1, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c")), - tc("SSHFP change algorithm", sshfp("@", 2, 1, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c")), - tc("SSHFP change value", sshfp("@", 2, 1, "745a635bc46a397a5c4f21d437483005bcc40d7511ff15fbfafe913a081559bc")), - tc("SSHFP change fingerprint", sshfp("@", 2, 2, "745a635bc46a397a5c4f21d437483005bcc40d7511ff15fbfafe913a081559bc")), - tc("SSHFP many records", sshfp("@", 1, 1, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c"), sshfp("@", 1, 2, "745a635bc46a397a5c4f21d437483005bcc40d7511ff15fbfafe913a081559bc"), sshfp("@", 2, 1, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c")), - tc("SSHFP delete", sshfp("@", 1, 1, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c")), + tc("SSHFP record", + sshfp("@", 1, 1, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c")), + tc("SSHFP change algorithm", + sshfp("@", 2, 1, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c")), + tc("SSHFP change type", + sshfp("@", 2, 2, "66c7d5540b7d75a1fb4c84febfa178ad99bdd67c")), + tc("SSHFP change fingerprint", + sshfp("@", 2, 2, "745a635bc46a397a5c4f21d437483005bcc40d7511ff15fbfafe913a081559bc")), + tc("SSHFP Delete one"), + tc("SSHFP add many records", + sshfp("@", 1, 1, "66666666666d75a1fb4c84febfa178ad99bdd67c"), + sshfp("@", 1, 2, "777777777777797a5c4f21d437483005bcc40d7511ff15fbfafe913a081559bc"), + sshfp("@", 2, 1, "8888888888888888fb4c84febfa178ad99bdd67c")), + tc("SSHFP delete two", + sshfp("@", 1, 1, "66666666666d75a1fb4c84febfa178ad99bdd67c")), ) } diff --git a/providers/namedotcom/namedotcomProvider.go b/providers/namedotcom/namedotcomProvider.go index 0dd8c8991..97db7520a 100644 --- a/providers/namedotcom/namedotcomProvider.go +++ b/providers/namedotcom/namedotcomProvider.go @@ -23,7 +23,7 @@ var features = providers.DocumentationNotes{ providers.CanUseAlias: providers.Can(), providers.CanUsePTR: providers.Cannot("PTR records are not supported (See Link)", "https://www.name.com/support/articles/205188508-Reverse-DNS-records"), providers.CanUseSRV: providers.Can(), - providers.CanUseTXTMulti: providers.Can(), + providers.CanUseTXTMulti: providers.Cannot(), providers.DocCreateDomains: providers.Cannot("New domains require registration"), providers.DocDualHost: providers.Cannot("Apex NS records not editable"), providers.DocOfficiallySupported: providers.Can(),