mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

DNSIMPLE: Support new name server handling changes (#1806)

Browse Source
This commit is contained in:
Amelia Aronsohn
2022-11-04 11:54:48 -07:00
committed by GitHub
parent 7fd35e85f8
commit a6043df648
1 changed files with 22 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
providers/dnsimple/dnsimpleProvider.go
View File

@ -49,7 +49,15 @@ var defaultNameServerNames = []string{
"ns1.dnsimple.com", "ns1.dnsimple.com",
"ns2.dnsimple.com", "ns2.dnsimple.com",
"ns3.dnsimple.com", "ns3.dnsimple.com",
"ns4.dnsimple.com", "ns4.dnsimple-edge.org",
}
var nameServerSuffixes = []string{
".dnsimple.com.",
".dnsimple-edge.org.",
".dnsimple-edge.net.",
".dnsimple-edge.io.",
".dnsimple-edge.com.",
} }
// dnsimpleProvider is the handle for this provider. // dnsimpleProvider is the handle for this provider.
@ -649,7 +657,7 @@ func removeOtherApexNS(dc *models.DomainConfig) {
// We ignore them, warning as needed. // We ignore them, warning as needed.
// Child delegations are supported so we allow non-apex NS records. // Child delegations are supported so we allow non-apex NS records.
if rec.GetLabelFQDN() == dc.Name { if rec.GetLabelFQDN() == dc.Name {
if !strings.HasSuffix(rec.GetTargetField(), ".dnsimple.com.") { if !isDnsimpleNameServerDomain(rec.GetTargetField()) {
printer.Printf("Warning: dnsimple.com does not allow NS records to be modified. %s will not be added.\n", rec.GetTargetField()) printer.Printf("Warning: dnsimple.com does not allow NS records to be modified. %s will not be added.\n", rec.GetTargetField())
} }
continue continue
@ -698,6 +706,7 @@ func getTargetRecordPriority(rc *models.RecordConfig) int {
} }
} }
// Compile the error messages returned by DNSimple's API into a single error message
func compileAttributeErrors(err *dnsimpleapi.ErrorResponse) error { func compileAttributeErrors(err *dnsimpleapi.ErrorResponse) error {
message := fmt.Sprintf("%d %s", err.HTTPResponse.StatusCode, err.Message) message := fmt.Sprintf("%d %s", err.HTTPResponse.StatusCode, err.Message)
for field, errors := range err.AttributeErrors { for field, errors := range err.AttributeErrors {
@ -706,3 +715,14 @@ func compileAttributeErrors(err *dnsimpleapi.ErrorResponse) error {
} }
return fmt.Errorf(message) return fmt.Errorf(message)
} }
// Return true if the string ends in one of DNSimple's name server domains
// False if anything else
func isDnsimpleNameServerDomain(name string) bool {
for _, i := range nameServerSuffixes {
if strings.HasSuffix(name, i) {
return true
}
}
return false
}