mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Make staticcheck more strict and fix new warnings

Browse Source
This commit is contained in:
Tom Limoncelli
2022-02-11 11:14:19 -05:00
parent d01a3cb8f6
commit a70354775e
16 changed files with 113 additions and 105 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
models/t_parse.go
View File

@ -12,43 +12,43 @@ import (
//
// If this doesn't work for all rtypes, process the special cases then
// call this for the remainder.
func (r *RecordConfig) PopulateFromString(rtype, contents, origin string) error {
if r.Type != "" && r.Type != rtype {
panic(fmt.Errorf("assertion failed: rtype already set (%s) (%s)", rtype, r.Type))
func (rc *RecordConfig) PopulateFromString(rtype, contents, origin string) error {
if rc.Type != "" && rc.Type != rtype {
panic(fmt.Errorf("assertion failed: rtype already set (%s) (%s)", rtype, rc.Type))
}
switch r.Type = rtype; rtype { // #rtype_variations
switch rc.Type = rtype; rtype { // #rtype_variations
case "A":
ip := net.ParseIP(contents)
if ip == nil || ip.To4() == nil {
return fmt.Errorf("invalid IP in A record: %s", contents)
}
return r.SetTargetIP(ip) // Reformat to canonical form.
return rc.SetTargetIP(ip) // Reformat to canonical form.
case "AAAA":
ip := net.ParseIP(contents)
if ip == nil || ip.To16() == nil {
return fmt.Errorf("invalid IP in AAAA record: %s", contents)
}
return r.SetTargetIP(ip) // Reformat to canonical form.
return rc.SetTargetIP(ip) // Reformat to canonical form.
case "AKAMAICDN", "ALIAS", "ANAME", "CNAME", "NS", "PTR":
return r.SetTarget(contents)
return rc.SetTarget(contents)
case "CAA":
return r.SetTargetCAAString(contents)
return rc.SetTargetCAAString(contents)
case "DS":
return r.SetTargetDSString(contents)
return rc.SetTargetDSString(contents)
case "MX":
return r.SetTargetMXString(contents)
return rc.SetTargetMXString(contents)
case "NAPTR":
return r.SetTargetNAPTRString(contents)
return rc.SetTargetNAPTRString(contents)
case "SRV":
return r.SetTargetSRVString(contents)
return rc.SetTargetSRVString(contents)
case "SOA":
return r.SetTargetSOAString(contents)
return rc.SetTargetSOAString(contents)
case "SSHFP":
return r.SetTargetSSHFPString(contents)
return rc.SetTargetSSHFPString(contents)
case "TLSA":
return r.SetTargetTLSAString(contents)
return rc.SetTargetTLSAString(contents)
case "SPF", "TXT":
return r.SetTargetTXTString(contents)
return rc.SetTargetTXTString(contents)
default:
return fmt.Errorf("unknown rtype (%s) when parsing (%s) domain=(%s)",
rtype, contents, origin)