mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

ROUTE53: Report R53_ALIAS loops as an error (#2111)

Browse Source
This commit is contained in:
Tom Limoncelli
2023-03-01 10:00:58 -05:00
committed by GitHub
parent 0d2a7bf93e
commit b54c5eab10
2 changed files with 32 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

23
providers/route53/auditrecords.go
View File

@@ -1,10 +1,31 @@
package route53
import "github.com/StackExchange/dnscontrol/v3/models"
import (
"fmt"
"github.com/StackExchange/dnscontrol/v3/models"
"github.com/StackExchange/dnscontrol/v3/pkg/rejectif"
)
// AuditRecords returns a list of errors corresponding to the records
// that aren't supported by this provider. If all records are
// supported, an empty list is returned.
func AuditRecords(records []*models.RecordConfig) []error {
a := rejectif.Auditor{}
a.Add("R53_ALIAS", rejectifTargetEqualsLabel) // Last verified 2023-03-01
return a.Audit(records)
}
// Normally this kind of function would be put in `pkg/rejectif` but
// since this is ROUTE53-specific, we'll include it here.
// rejectifTargetEqualsLabel rejects an ALIAS that would create a loop.
func rejectifTargetEqualsLabel(rc *models.RecordConfig) error {
if (rc.GetLabelFQDN() + ".") == rc.GetTargetField() {
return fmt.Errorf("alias target loop")
}
return nil
}