mirror/stackexchange-dnscontrol
1
0
Fork 0
mirror of https://github.com/StackExchange/dnscontrol.git synced 2024-05-11 05:55:12 +00:00
Code Issues Releases Activity

Vet and Lint the entire system (#296)

Browse Source 
* govet and golint corrections
This commit is contained in:
Tom Limoncelli
2018-01-09 12:53:16 -05:00
committed by GitHub
parent 1a91a7f536
commit b7c251190f
64 changed files with 540 additions and 433 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/spflib/parse.go
View File

@ -9,10 +9,12 @@ import (
"io"
)
// SPFRecord stores the parts of an SPF record.
type SPFRecord struct {
Parts []*SPFPart
}
// Lookups returns the number of DNS lookups required by s.
func (s *SPFRecord) Lookups() int {
count := 0
for _, p := range s.Parts {
@ -26,6 +28,7 @@ func (s *SPFRecord) Lookups() int {
return count
}
// SPFPart stores a part of an SPF record, with attributes.
type SPFPart struct {
Text string
IsLookup bool
@ -40,6 +43,7 @@ var qualifiers = map[byte]bool{
'+': true,
}
// Parse parses a raw SPF record.
func Parse(text string, dnsres Resolver) (*SPFRecord, error) {
if !strings.HasPrefix(text, "v=spf1 ") {
return nil, fmt.Errorf("Not an spf record")
@ -53,12 +57,12 @@ func Parse(text string, dnsres Resolver) (*SPFRecord, error) {
}
rec.Parts = append(rec.Parts, p)
if part == "all" {
//all. nothing else matters.
// all. nothing else matters.
break
} else if strings.HasPrefix(part, "a") || strings.HasPrefix(part, "mx") {
p.IsLookup = true
} else if strings.HasPrefix(part, "ip4:") || strings.HasPrefix(part, "ip6:") {
//ip address, 0 lookups
// ip address, 0 lookups
continue
} else if strings.HasPrefix(part, "include:") {
p.IsLookup = true
@ -100,8 +104,9 @@ func dump(rec *SPFRecord, indent string, w io.Writer) {
}
}
func (rec *SPFRecord) Print() string {
// Print prints an SPFRecord.
func (s *SPFRecord) Print() string {
w := &bytes.Buffer{}
dump(rec, "", w)
dump(s, "", w)
return w.String()
}